Performance issue
craciu25yt opened this issue ยท 10 comments
I'm changing some settings & mods in Fabulosly Optimized to get more performance and I'm testing the FPS, CPU and GPU usage in a void world looking at north with pitch 0 to make all of them fair and I found that disabling dynamic fps there's more instability in the fps and there's like ~1300 -1500 fps and without it ~1550 -1700 FPS
And removing the mod worsens your FPS? Like I said, the only way I could see that happening was if it was helping alleviate thermal throttling.
So Dynamic FPS is somehow improving your FPS and making it more stable? That sounds to me like there must be some confounding factors in the tests, because Dynamic FPS has no way to ever improve your FPS (except letting your CPU cool down when tabbed out, which helps if it's throttling due to thermal constraints). Especially at such high frame rates you may be turning code paths into bottlenecks that are not designed with performance in mind.
Unless you mean the "Disable Dynamic FPS" keybind to disable the mod's behavior? This also could not possibly worsen performance: while disabled, the injected code to check if the next frame should be rendered is exited as early as possible, always allowing the render to go through. The relevant code:
Ahh, that makes more sense. I'll still maintain, though, that performance at such high FPS numbers really isn't meaningful.
Especially at such high frame rates you may be turning code paths into bottlenecks that are not designed with performance in mind.
A change that doubles your fps from 60 to 120 would be incredibly unlikely to double it to 1200 if you started at 600. The game (and most mods) are simply not designed with FPS that high in mind.
but if it has ~200 fps performance impact for me, it wouldn't in a low-end pc (for more context, I'm trying to do the most optimised modpack)
If it reduces your fps from 1700 to 1500 (so by ~12%), that does not mean it would reduce someone else's fps from 60 to 53 (also ~12%), because the relevant bottlenecks might be completely different. So in practice it's not important, and high FPS numbers are meaningless.
