Dynamic Lights

Dynamic Lights

15M Downloads

RUINSTRIGGER scans the global te tick list

sfPlayer1 opened this issue ยท 4 comments

commented

https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/blob/1.8/Ruins/src/main/java/atomicstryker/ruins/common/RuinsMod.java#L120

This scans the world's list, which isn't a great idea from a performance POV, and happens to conflict with Fastcraft avoiding to tick non-tickable tile entities. I could of course work around this, but the code should really scan the chunk's te map instead.

commented

While the code is triggered by the player entering a chunk, it isn't exclusive to the chunk being entered. The set distance of 64 is multiple chunks across, so the chunk te map won't be enough. I could of course do something elaborate and have it scan the relevant adjacent chunks ...

commented

Like this 4c134ef

commented

Ah I didn't look too closely, but this looks good. Scanning 81 chunks may potentially cause issues with heavy microblock/chisel users though.

commented

ANYTHING causes issues with mods that overload a feature past the point of ridicule. What people are doing to nbt tags...