Dynamic Surroundings

Dynamic Surroundings

65M Downloads

Mace, Trident, and many modded weapons lacking sounds

Minecatr opened this issue ยท 5 comments

commented

At least for 1.21.1 NeoForge there are no weapon sounds for the trident or mace, this also applies to many modded weapons that aren't necessarily swords. This could be fixed/improved by adding a config similar to better combat where you can specify extra weapons that should make sounds.

Here is an example of a mod that is incompatible:
https://modrinth.com/mod/l2weaponry

commented

IIRC at the time there weren't any formal "#c" tags for these items, or mods didn't have their own tags for them. I put off going through all the grunge work of finding all the mods and manually adding tags. Here is an example of how tags would be applied for axes: https://github.com/OreCruncher/DynamicSurroundingsFabric/blob/main/common/src/main/resources/assets/dsurround/dsconfigs/tags/item/effects/axes.json

[Yes, Dynamic Surroundings is 100% client side. It does make use of tags like server-side data packs and configurations.]

commented

Ahh, so I can use kubejs to add these tags

commented

I haven't tried that. If you give it a shot let me know how it goes.

commented

Yeah, it worked. The best way I found is to just add on 'c:swords' or 'c:axes' to whatever modded tag i'm not sure if adding these tags has any side effects though.

commented

Add dsurround:axes and dsurround:swords instead. These are the tags that DS actually uses. In my tag definitions they refer to the corresponding c tags.