Dynamic Surroundings

Dynamic Surroundings

51M Downloads

1.12.2 Biome Bundle/OTG Sound Loop Crash

Arcaes opened this issue ยท 13 comments

commented

Mod Version:
1.12.2
Forge Version:
forge-1.12.2-14.23.0.2542

Link to crash log (if applicable):
[01:04:05] [main/WARN] [dsurround]: Biome [SavannaEdge] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[01:04:05] [main/WARN] [FML]: No types have been added to Biome minecraft:void, types have been assigned on a best-effort guess: [PLAINS]
[01:04:05] [main/INFO] [dsurround]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/INFO] [dsurround]: CLIENT: Executing script for mod [mcp]
[01:04:05] [main/WARN] [dsurround]: Unable to locate biome [SavannaEdge] (com.pg85.otg.forge.generator.OTGBiome) after reload
[01:04:05] [main/WARN] [dsurround]: Biome [SavannaEdge] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[01:04:05] [main/INFO] [dsurround]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/INFO] [dsurround]: CLIENT: Executing script for mod [mcp]
[01:04:05] [main/WARN] [dsurround]: Unable to locate biome [SavannaEdge] (com.pg85.otg.forge.generator.OTGBiome) after reload
[01:04:05] [main/WARN] [dsurround]: Biome [SavannaEdge] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[01:04:05] [main/INFO] [dsurround]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/INFO] [dsurround]: CLIENT: Executing script for mod [mcp]
[01:04:05] [main/WARN] [dsurround]: Unable to locate biome [SavannaEdge] (com.pg85.otg.forge.generator.OTGBiome) after reload
[01:04:05] [main/WARN] [dsurround]: Biome [SavannaEdge] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[01:04:05] [main/INFO] [dsurround]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/INFO] [dsurround]: CLIENT: Executing script for mod [mcp]
[01:04:05] [main/WARN] [dsurround]: Unable to locate biome [SavannaEdge] (com.pg85.otg.forge.generator.OTGBiome) after reload
[01:04:05] [main/INFO] [dsurround]: DimensionInfo{id=0, name=overworld, seaLevel=63, cloudHeight=128, skyHeight=256, haze=true, aurora=true, weather=true, fog=true}
[01:04:05] [main/WARN] [dsurround]: Biome [SavannaEdge] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[01:04:05] [main/INFO] [dsurround]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]
[01:04:05] [main/WARN] [dsurround]: Cannot find sound that should be registered [meta:missing_sound]

Then this repeats at an impressive rate infinitley.

Description:
Howdy, using latest version of OTG and BiomeBundle. This crash only occurs in loading certain biomes, otherwise mod works fine. BiomeBundle is not technically updated for 1.12.2, but I am unsure if this type of problem would be fixed by anything changed by an official update. Once chunk containing certain biome is loaded, this "crash" (it just slows MC down so its unusable) happens. I tried disabling biome sounds, and got a similar crash with different sound message. Is it possible to fix this or disable DSurroundings custom sounds altogether? Either of those would help plenty. Thanks.

commented

@PG85 Is this similar to #85 do you think?

commented

Am having the exact same issue, running the latest version of both mods. It's not crashing per se, but it is causing the game to freeze forcing me to close it forcefully. As extra info, when in a Biome Bundle world, the game's frames drop significantly near water.

commented

Same issue for me. I'm using a OTG+BB+DS-only modpack (nothing else installed)

MC: 1.12.2
Forge: 14.23.1.2556
DynamicSurroundings: 3.4.7.2
OTG: 1.12.2 v2
BB: v6

I did a quick test with debugging enabled:

[18:25:32] [main/INFO]: > QUEUED: [SpotSound{dsurround:ice, BLOCKS, state=PLAYING, v=0.5, p=1.0, s=1.0, LINEAR, x=351.5, y=61.5, z=287.5}]
[18:25:33] [main/INFO]: > QUEUED: [SpotSound{dsurround:ice, BLOCKS, state=PLAYING, v=0.5, p=1.0, s=1.0, LINEAR, x=357.5, y=62.5, z=290.5}]
[18:25:39] [main/INFO]: > QUEUED: [MusicSound{minecraft:music.creative, MUSIC, state=PLAYING, v=1.0, p=1.0, s=1.0, NONE, x=0.0, y=0.0, z=0.0}]
[18:25:39] [main/WARN]: Biome [Frozen Forest] not detected during initialization - forcing reload (class com.pg85.otg.forge.generator.OTGBiome)
[18:25:39] [main/WARN]: No types have been added to Biome minecraft:void, types have been assigned on a best-effort guess: [PLAINS]
[18:25:39] [main/INFO]: Resource pack DEFAULT: Presence by Ha3 (http://presencefootsteps.ha3.eu)
[18:25:39] [main/WARN]: Cannot find sound that should be registered [meta:missing_sound]
[18:25:39] [main/WARN]: Cannot find sound that should be registered [meta:missing_sound]
[18:25:39] [main/INFO]: CLIENT: Executing script for mod [mcp]
[18:25:39] [main/INFO]: *** BIOME REGISTRY ***
[18:25:39] [main/INFO]: Biome [BattleMusic/dsurround:fake_battlemusic] (-210):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:battle.normal(battle.inBattle && !battle.isBoss), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: +   [dsurround:battle.miniboss(battle.isBoss && !(battle.isWither || battle.isDragon)), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: +   [dsurround:battle.wither(battle.isWither), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: +   [dsurround:battle.dragon(battle.isDragon), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Dynamic Surroundings Battle Music
[18:25:39] [main/INFO]: Biome [Clouds/dsurround:fake_clouds] (-208):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:wind(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Clouds explicit set
[18:25:39] [main/INFO]: Biome [Hell/minecraft:hell] (8):
[18:25:39] [main/INFO]: + <NETHER,HOT,DRY>
[18:25:39] [main/INFO]: + temp: 2.0 (hot) rain: 0.0 DUST dustColor:[r:255,g:0,b:0]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Regular Nether
[18:25:39] [main/INFO]: Biome [OuterSpace/dsurround:fake_outerspace] (-207):
[18:25:39] [main/INFO]: Biome [Player/dsurround:fake_player] (-202):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:heartbeat(player.isHurt && !player.isDead), v:1.0, p:1.0, t:PERIODIC]
[18:25:39] [main/INFO]: +   [dsurround:tummy(player.isHungry && !player.isDead), v:1.0, p:1.0, t:PERIODIC, d:300+0]
[18:25:39] [main/INFO]: +   [dsurround:dimension.nether(player.dimension == -1), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Player explicit set
[18:25:39] [main/INFO]: Biome [The End/minecraft:sky] (9):
[18:25:39] [main/INFO]: + <COLD,END,DRY>
[18:25:39] [main/INFO]: + temp: 0.5 (mild) rain: 0.5
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:theend(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   It's The End!
[18:25:39] [main/INFO]: +   > Sound Reset
[18:25:39] [main/INFO]: Biome [The Void/minecraft:void] (127):
[18:25:39] [main/INFO]: + <PLAINS>
[18:25:39] [main/INFO]: + temp: 0.5 (mild) rain: 0.5
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:theend(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Basic Plains
[18:25:39] [main/INFO]: +   Bison!
[18:25:39] [main/INFO]: +   Insect buzz
[18:25:39] [main/INFO]: +   Coyote
[18:25:39] [main/INFO]: +   Crow
[18:25:39] [main/INFO]: +   Owl
[18:25:39] [main/INFO]: +   Raptors
[18:25:39] [main/INFO]: +   It's The End!
[18:25:39] [main/INFO]: +   > Sound Reset
[18:25:39] [main/INFO]: Biome [UnderDOCN/dsurround:fake_underdocn] (-205):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:underdeepocean(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + spot sound chance:250
[18:25:39] [main/INFO]: + spot sounds [
[18:25:39] [main/INFO]: +   [dsurround:whale(), v:1.0, p:1.0, t:SPOT, w:10]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Under Deep Ocean explicit set
[18:25:39] [main/INFO]: Biome [UnderOCN/dsurround:fake_underocn] (-204):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:underocean(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Under Ocean explicit set
[18:25:39] [main/INFO]: Biome [UnderRVR/dsurround:fake_underrvr] (-206):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:underriver(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Under River explicit set
[18:25:39] [main/INFO]: Biome [Underground/dsurround:fake_underground] (-201):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:underground(player.isInside && player.Y < 33), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + spot sound chance:250
[18:25:39] [main/INFO]: + spot sounds [
[18:25:39] [main/INFO]: +   [dsurround:rockfall(), v:1.0, p:1.0, t:SPOT, w:30]
[18:25:39] [main/INFO]: +   [dsurround:bigrockfall(), v:1.0, p:1.0, t:SPOT, w:15]
[18:25:39] [main/INFO]: +   [dsurround:monstergrowl(isNight), v:1.0, p:1.0, t:SPOT, w:10]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Underground explicit set
[18:25:39] [main/INFO]: Biome [Underwater/dsurround:fake_underwater] (-203):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:underwater(), v:1.0, p:1.0, t:BACKGROUND]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Underwater explicit set
[18:25:39] [main/INFO]: Biome [Village/dsurround:fake_village] (-209):
[18:25:39] [main/INFO]: + sounds [
[18:25:39] [main/INFO]: +   [dsurround:village.rooster(player.dimension == 0 && !player.isInside && isSunrise && weather.isNotRaining), v:1.0, p:1.0, t:PERIODIC, d:100+100]
[18:25:39] [main/INFO]: +   [dsurround:village.anvil(player.dimension == 0 && !player.isInside && isDay && weather.isNotRaining), v:1.0, p:1.0, t:PERIODIC, d:1200+2400]
[18:25:39] [main/INFO]: +   [dsurround:village.dogbark(player.dimension == 0 && !player.isInside && weather.isNotRaining), v:1.0, p:1.0, t:PERIODIC, d:200+200]
[18:25:39] [main/INFO]: + ]
[18:25:39] [main/INFO]: + comments:
[18:25:39] [main/INFO]: +   Village explicit set
[18:25:39] [main/INFO]: Biome [WTFJustHappened/dsurround:fake_wtfjusthappened] (-211):
[18:25:39] [main/INFO]: *** DIMENSION REGISTRY (cache) ***
[18:25:39] [main/INFO]: dimensionId: 0 hasAurora: true hasHaze: true hasWeather: true hasFog: true 
[18:25:39] [main/INFO]: dimensionId: -1 seaLevel: 0 hasWeather: true hasFog: true 
[18:25:39] [main/INFO]: dimensionId: 1 seaLevel: 0 cloudHeight: 128 
[18:25:39] [main/INFO]: Culling sound 'minecraft:entity.cow.ambient'
[18:25:39] [main/INFO]: Culling sound 'minecraft:entity.sheep.ambient'
[18:25:39] [main/INFO]: Blocking sound 'dsurround:bison'
[18:25:39] [main/INFO]: Culling sound 'minecraft:entity.chicken.ambient'
[18:25:39] [main/INFO]: Culling sound 'minecraft:block.water.ambient'
[18:25:39] [main/INFO]: Culling sound 'minecraft:entity.pig.ambient'
[18:25:39] [main/INFO]: Culling sound 'minecraft:block.lava.ambient'
[18:25:39] [main/WARN]: Unable to locate biome [Frozen Forest] (com.pg85.otg.forge.generator.OTGBiome) after reload

Hope this helps.

And btw. "Biome [WTFJustHappened/dsurround:fake_wtfjusthappened]" is pretty funny ๐Ÿ‘

commented

@Zhaltor I believe that the "lag near oceans" issue is because of the way DS generates its water splash particles. Biome Bundle's oceans generate a lot of blocks of flowing water downwards, which is likely not intended behavior but it isn't really harmful. However, DS recognizes each flowing water block as a waterfall and generates a metric ton of splash particles all across the ocean. Try setting this option in the config and see if that helps the lag:
B:"Enable Water Splash"=false

commented

@Luke616 Thanks, though it does not help much considering the game becomes unplayable at random when exploring due to an unknown issue.

commented

@Zhaltor lol yeh hopefully this issue gets addressed soon

commented

FYI: @Zhaltor OTG (/w Biome Bundle) producing tons of AIR blocks in water biomes and subsequently spamming the client with splashes is now fixed; PG85/OpenTerrainGenerator#84

But the "[18:25:39] [main/WARN]: Unable to locate biome [Frozen Forest] (com.pg85.otg.forge.generator.OTGBiome) after reload" looping behaviour is still a problem.

commented

Yep have the same problem this is reallllly annoying hopefully this gets fixed soon as I love both the mods :/

commented

I plan to get back to this in a week or so when Xmas break comes. Should have time to address then.

commented

@OreCruncher Same here, have been busy lately but I hope to have time around Xmas to look at some mod compatiblity issues :).

commented

Hi,
Thanks for your awesome mod orecruncher. I've had this issue as well, wanted to make my biomes look better but sudden lag until I uninstalled dynamic surroundings. Any eta on the next build that will include this fix? I see you said its been fixed 2 days ago.

commented

Fixed means I committed it to GitHub. I plan to publish a BETA containing the fix sometime on 1/6.

commented

Post v3.4.8.1 with the compat changes.