Make battle music only activate for hostile mobs, and some neutral mobs

Question

Make battle music only activate for hostile mobs, and some neutral mobs

darthvader45 opened this issue 7 years ago · 16 comments

darthvader45 commented 7 years ago

Description:
Maybe allow for battle music to only be played for entities that extend EntityMob or similar? Keep hearing the battle music when my Animania rams butt heads (because they apparently are supposed to become hostile to each other)

darthvader45 commented 7 years ago

1.11.2

darthvader45 · Answer 1 · 2017-12-28T23:16:33.000Z

What's supposed to change?

…

On Thu, Dec 28, 2017 at 1:20 PM, OreCruncher ***@***.***> wrote: Give this a whirl: https://github.com/OreCruncher/ DynamicSurroundings/releases/tag/v1.11.2-3.4.8.0T2 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#190 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACr5pLOzqZjOsWo5xTIYF4zHjV-K8UIsks5tE9vugaJpZM4Q98Zk> .

-- Golden rule in Minecraft: Never dig straight down.

OreCruncher · Answer 2 · 2017-12-29T00:54:35.000Z

The rams shouldn't trigger the battle music. Assuming they aren't IMobs.

OreCruncher · Answer 3 · 2017-12-28T15:28:25.000Z

I will need to take a look at this. I would think there would be a way to filter some more.

darthvader45 · Answer 4 · 2017-12-28T16:26:36.000Z

Alrighty, no need to rush, take your time.

…

On Thu, Dec 28, 2017 at 10:28 AM, OreCruncher ***@***.***> wrote: I will need to take a look at this. I would think there would be a way to filter some more. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#190 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACr5pDCHiSrfkSZzky5phgNfZPZKhiroks5tE7OZgaJpZM4Q98Zk> .

-- Golden rule in Minecraft: Never dig straight down.

OreCruncher · Answer 5 · 2017-12-28T16:38:32.000Z

Main issue at the moment is not enough coffee. :)

darthvader45 · Answer 6 · 2017-12-28T16:40:03.000Z

Heh, then more coffee is in order.

OreCruncher · Answer 7 · 2017-12-28T17:13:53.000Z

Which version of MC are you using? I want to post a test JAR for you to try out.

OreCruncher · Answer 8 · 2017-12-28T18:20:29.000Z

Give this a whirl: https://github.com/OreCruncher/DynamicSurroundings/releases/tag/v1.11.2-3.4.8.0T2

darthvader45 · Answer 9 · 2017-12-29T16:26:06.000Z

Okay, testing with my medieval mod setup, as that has a bunch of rams in close quarters, meaning they fight often.

darthvader45 · Answer 10 · 2017-12-29T16:45:17.000Z

Well it works flawlessly.

OreCruncher · Answer 11 · 2017-12-29T16:46:26.000Z

Nice! The change will be in the next official build. Thanks for checking.

darthvader45 · Answer 12 · 2017-12-29T16:53:22.000Z

No problem. If you manage to compile a test jar of the sound engine fix, I'd love to test it out.

…

On Fri, Dec 29, 2017 at 11:46 AM, OreCruncher ***@***.***> wrote: Nice! The change will be in the next official build. Thanks for checking. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#190 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACr5pKxUsLM8kOphPMuuCLU3pZkkuhXXks5tFRdigaJpZM4Q98Zk> .

-- Golden rule in Minecraft: Never dig straight down.

OreCruncher · Answer 13 · 2017-12-29T16:54:14.000Z

Actually the test JAR you currently have contains that fix as well.

darthvader45 · Answer 14 · 2017-12-29T17:22:59.000Z

Oh, wow. This could be the fix I've waited for. This'll save a lot of problems.

OreCruncher · Answer 15 · 2018-01-03T01:36:57.000Z

Pushed v3.4.8.0 with fixes.

Share to