Dynamic Surroundings

Dynamic Surroundings

51M Downloads

Splashing water colour

Opened this issue ยท 11 comments

commented

Mod Version:

DynamicSurroundings-1.12.2-3.4.8.3.jar

Forge Version:

14.23.1.2589

Link to crash log (if applicable):

Description:
Am i right in thinking your mod adds splashing effects when water falls from height onto other water? if so I'm in a wasteland biome generated by Biomes of Plenty. The water is green yet the splash particles are blue. They should be green also?

Is this something you could fix? Splash particles based on colour of the water?

commented

I been noticing the same thing. I will have to dig into it to see what I can do. I think it would be possible.

commented

Pushed v3.4.8.4 to CurseForge.

commented

Hi thank you for the extremely fast response, but...

these were the splash effects I was trying to explain - see they are blue, this photo is taken with DynamicSurroundings-1.12.2-3.4.8.4

image here

commented

That is weird. Should be colorized. I will take a look.

commented

Try this jar and let me know how it looks: https://github.com/OreCruncher/DynamicSurroundings/releases/tag/v3.4.8.5T

This is from my current sandbox and the splash particles are rendering correctly in BoP biome that has tinted water.

commented

by George hes done it !

Perfect.

Thank you

commented

No problem. I was working on Albedo compat and came across some interesting gems in the process. :) BTW, do you use Albedo?

commented

Never even heard of it until now - but it seems it can add some very nice colour effects

commented

Just by itself it modifies MC lighting to improve it. But yes, other mods out there take advantage of it to do lighting effects. For example DS puts a glow around fireflies, and when you hold a lit item, like a torch, it will cast a light halo around the player.

commented

I'm gonna have to try that now, lol

commented

I like the albedo torches mod, coloured torches should be a Minecraft Vanilla thing