[1.12.2] Incompatibility with Weather2. *Rain sounds stop playing after a couple seconds when it starts to rain.*
SonicX8000 opened this issue ยท 13 comments
Referenced Issue.
Corosauce/weather2#236
Minecraft: 1.12.2
Forge: 14.23.3.2673
Mods:
coroutil-1.12.1-1.2.5
DynamicSurroundings-1.12.2-3.4.9.12
weather2-1.12.1-2.6.4
When it rains with Weather 2 you hear the rain sounds, however overtime the rain splash particles will change to these fog-like particles and that's when the rain sounds will mute itself.
Unless I need to tweak some config settings to get the rain sounds to play correctly. All config settings are at their default settings.
EDIT
The rain sounds do come back after awhile but it seems to be random.
To give you a headstart, my shaders might be messing with it, try setting useEntityRenderHookForShaders to false in coroutil/General.cfg (formally CoroUtil.cfg), noticed that vanilla rain looks weird and faded (messed up looking at water) if you have Particle_RainSnow to false, I might have to improve that.
I'll probably fiddle with dynamic surroundings more soon to get a better feel for how they interact.
Setting "useEntityRenderHookForShaders" to false didn't seem to do anything. Rain sounds still cut out & return.
Some further testing by using a Weather Machine to force it to rain... it seems that if it rains long enough to where you get 'heavy' rainfall... that's when the rain sounds stop. If I break the Weather Machine the heavy rainfall will begin to die down, once that happens then the rain sounds play again until it stops raining.
I'm using 'coroutil-1.12.1-1.2.6', other mods are still the same.
Gave it a go with disabling "Particle_RainSnow" for Weather 2. Results in no rain particles rendering at all and Rain Sound still cuts out but comes back at certain times. Dynamic Surroundings Config still at default settings.
Something may have changed in Weather2. Will need to check it out. The sounds for rain are generated at the time particles are generated. Mods that change this behavior have to use ASM to hook it. It is possible that DS and Weather2 are now conflicting.
This bug with the rain sounds is still present using these mods:
coroutil-1.12.1-1.2.7
DynamicSurroundings-1.12.2-3.4.9.13
weather2-1.12.1-2.6.8
I have uploaded a video of the bug with the rain sound bug, hope this helps. Should've posted this earlier but had some technical difficulties with the recording setup since I last recorded something.
Related to sounds those are generated during the "addRainParticles" call. DS uses ASM to hook this method. If Weather2 also uses ASM to hook a conflict arises.
DS also hooks the weather renderer and if Weather2 replaces after the fact normal rainfall/snow/dust rendering will not occur.
In general I recommend turning off DS ASM related to weather if Weather2 is installed. My view is that since Weather2 is essentially providing weather effects DS should not be involved in that. You can disable DS hooking by setting "Enable Weather Control" under the ASM options to FALSE. A client restart will be required.
In terms of actual weather handling (driving the weather windows and such) DS will default to letting Vanilla do the heavy lifting if Weather2 is installed. My presumption is that Weather2 will do the necessary hand holding of Vanilla and DS is going along for the ride.
EDIT: One more thing in case it comes up. Weather2 does affect particle motion when the wind blows. This does not work on the majority of DS particles because DS particle handling is handled directly by DS and not the Minecraft ParticleManager. I am not sure how to go about resolving this. (DS does it's own particle handling for performance reasons.)
Setting "Enable Weather Control" to 'False' in DS did the trick. The rain sound plays fully even at heavy rainfall with Weather2.
As for particles... Weather2's wind affects all particles as far as I know... but there's a config option to only have it affect Vanilla & Weather Particles called "Particle_VanillaAndWeatherOnly". It was odd having it affect certain particles in my eyes such as Botania's Particles like the light sources from the Mana Blaster, the Starfield Creator, PSI's Particle-Framed Blocks, etc.
I suppose this could be marked as solved since the rain sound no longer drops out when "Enable Weather Control" is set to 'False'. Thank you for your help.
Nothing does work for me. My rain have no sound. Can anyone help me?