Dynamic Surroundings

Dynamic Surroundings

51M Downloads

Weather dose not work with JED dimensions

CapturedCherry-zz opened this issue ยท 4 comments

commented

Mod Version:
1.12.2-3.4.9.12.jar
Forge Version:
14.23.3.2655

Link to crash log (if applicable):
latest.log

Description:
When I make a new world with the a JED dimension, I spawn in with thunder and rain turned on which is what I want. But when DynamicSurroundings is added to the pack that does not happen the world spawns, but without the rain and thunder. I have asked the JED mod creator and he has said that it could be an issue with DynamicSurroundings because the vanilla level NBT are right for what I am doing. Dose this mod added its own weather. If so how do I tell JED to use your weather inside of vanilla.

commented

#245. If JED does not use the WorldInfo object for recording rain info things can get weird. I have not spent time, in detail, to see what is going on.

commented

Ok thanks. Will there be some type of fix in the future. Maybe DS can look for a dimensions.json file in its config folder. This will let modpack makers tell DS what dimensions they want the weather and sounds to work for. (I know that it is not that simple but its just an idea)

commented

Pushed a BETA of v3.5 to CurseForge. Note that the new version has a library dependency on OreLib (another library mod I made). Make sure you read the release notes prior to upgrade.

commented

I am looking into this issue. What do I have to do with it to see the problems you are seeing?

EDIT: OK - here is what is going on. By default DS assumes that a dimension it does not know about has no weather and that configuration files would be provided to tell DS to do whatever weather wise. So for the current shipping versions a JSON would have to be created that has the appropriate info, and placed into the dsurround config directory.

For 3.5 I am changing the default to be smarter. I am going to have it do weather for the dimension IIF it is considered a surface world and can see sky. This should address the vast majority of modded dimensions.