Mod Version: DynamicSurroundings-1.12.2-3.4.9.13.jar

Forge Version: Build 2705

Description:

I'd like to request some settings to adjust aurora quality. The debug profiler shows aurora renders are taking ~200ms.... that's a lot, and seems to be contributing to FPS drops (processing is at 140ms while standing still, at night, in a taiga.)

Could a setting be added for Low/Med/High quality auroras to help combat this please?

Only option is to disable the use of shaders. BTW, what video card do you have?

GTX 1070

That is weird. I have a GTX 980 and it runs much much much faster. Are you running a shader pack?

EDIT: Example - under the debugger on my system the timing value shows ~0.23ms time taken for the client tick when rendering a double band aurora, which is over 600 times faster than what you are reporting. Should note that I am using Forge 2655 since that is the minimum supported version for DS.

Not sure whether it is the shader pack or not. Quick way to find out is disabling it and checking the numbers again. In general, though, my rig performs much much better for some reason than yours. What version of OptiFine are you running?

D3 for 1.12. I'm also using 32x resource packs and have stuff like BetterFoliage on (along with BetterFPS and Foamfix), all my configs are as tweaked as I could make them. Still runs everything at ~60fps on average, but being in forests with auroras seems to be a bad combination overall.

(Yes I'm aware I'm probably expecting a lot out of that combination, I'm trying it to see if it works. If it doesn't, then it doesn't. :)

Can you link a screenshot of the debug screen with the DS timing values? It may have further clues in the other data points.

Yep, I'm running Sildur's Enhanced Default. Should I request an option on the shader author's side then you think? I honestly didn't realize auroras would be impacted by the shader before asking, my apologies.

Okay, after you said that I learned something else I think. Do auroras cast light onto blocks, etc.?

What finally made the FPS go back up is setting shadow distance to medium instead of Far, and turning off colored shadows entirely. That had never been a problem before the auroras so I don't know if they're actually related or not... maybe just a coincidence??

If it's still useful though I can upload a few screenshots of the render times on both a 1070 and a gtx 980 with the same modpack and resourcepack (one PC is the server).

No - auroras don't cast light. Or more specifically, the aurora shader does not do any fancy lighting. Can't speak for what the shader pack is doing. It doesn't do any shadowing either. Best way to think of the aurora is as texture that is dynamically generated and rendered onto a triangle strip.

EDIT: An no, given what you discovered I do not think the screen shots would be helpful.

Alright, thanks for your patience with this.

I may have spoken too soon with the shader option change... :/ Either way, I asked about it on the shader dev's forum topic.

Screenshot from just now

That number is the aggregate amount of time taken during the client tick to do rendering. Divide that number by your FPS and that tells you how long it takes to render in a single render pass. Based on the screenshot it would be 0.241/32 = 0.0075ms for a single frame render.

EDIT: Should also mention that the timing values will change, typically to lower values, as you play the game. The reason is that the JIT compiler in the JVM will compile the code to native code at some point. Typically when this happens I see a 30% performance improvement on my rig.

Oh hmm. So theoretically I should check framerates and render times over subsequent nights, then?

Thanks for the extra information, this will at least help me not report or request things that don't make sense in the future...!

No worries. I would rather hear about things rather than not. :)

According to that screenshot the render time is 0.241ms of the client tick as compared to the original 200ms. Maybe you are reading it wrong?

No sorry I mistyped the original comment, should have been ~0.200ms.

Though this is an older issue I am marking it fixed. In the 3.6.0.0 release I optimized the aurora shader and rendering code. I can get 120 FPS with a 3 band aurora on my GTX 980.

Pushed v3.6.0.0 to CurseForge. Contains major changes to aurora rendering performance.