Dynamic Surroundings

Dynamic Surroundings

51M Downloads

Crash when trying to disable DynSurroundings via fmlModState.properties

NikkyAI opened this issue ยท 9 comments

commented

Mod Version:
1.12.2-3.4.9.14

Forge Version:
14.23.4.2705

Link to crash log (if applicable):
https://gist.github.com/0e3dbbcc34ff1f05c3deb3fd13037f27

Description:
using player's choice which configured the fmlModState.properties file
on server / world join it crashes,
seems like either fml or this mod is behaving silly

commented

My money is on FML. DS uses ASM to hook that routine when the DS coremod runs. I have never disabled a mod using that feature (because I think it is incomplete). Do you also have to disable the coremod as well?

commented

OreCruncher thank you for pointing that out it helped out tons

this should work :D I have tested it out and works for me. This is from my script so you can just add the extraMods line.
{
"id": "dsurround",
"name": "Dynamic Surroundings",
"desc": "Adds a variety of sound and visual effects to improve your Minecraft experience.",
"website": "https://minecraft.curseforge.com/projects/dynamic-surroundings",
"category": "Sounds",
"extraMods": ["presets", "dynamicsurroundingscore"],
"base": false
}

Doesn't work for some reason now.

commented

I'm not going to try and do anything with this. Apparently this feature is going to be removed in Forge 1.13. Link here.

commented

I spent some time looking at it figuring out that it was half way implemented to find out that it's going to be removed. Not sure if I should be happy or sad. :)

commented

ok np :D

commented

should this be closed then ?
i will close it
i am not trying to use this anymore and it does not have any future

commented

we have dropped players choice and have not attepted anything further, the fml feature seems to not be that widely supported
i will leave ths issue open until someone can validate that the suggested config works

commented

@NikkyAI Have you made further progress with the changes @Zer0Lyfe pointed out?

commented

@OreCruncher
For some reason my playerchoices file has seemed to start to not work now but seems to be different crash. It looks like it now isn't disabling the core mod for some reason. The mods are the same version and i have tried the earlier versions (.2705) as well. this is the crash logs.

https://paste.dimdev.org/qawegakeqa.mccrash
the one above has the same player choice as my last comment

with less mods:
https://gist.github.com/Zer0Lyfe/1a08e31d4d06953cf60f86ea52afd418
With less mods player choice file:
https://gist.github.com/Zer0Lyfe/d36fefc5355050d608c5f8ffde28f48e