Dynamic Surroundings

Dynamic Surroundings

51M Downloads

custom.json not loading 1.10.2

resinate opened this issue ยท 11 comments

commented

Mod Version:
DynamicSurroundings-1.10.2-3.4.9.14.jar
Forge Version:
forge-12.18.3.2511

Link to crash log (if applicable):

Description:
changing custom fog color in json doesnt work anymore and wiki is severely out of date with no working links.

        "biomeName":"Underworld",
		"dust":false,
		"dustColor":"0,0,0",
		"fog":true,
		"fogDensity":0.25,
		"fogColor":"160,150,150"

i use custom biome its worked before

commented

Post the complete JSON please.

commented

@resinate Following up. :)

commented

sry for LATE reply....

{
"biomes":[
{
"biomeName":"Northrend",
"dust":false,
"dustColor":"255,255,255",
"fog":true,
"fogDensity":0.40,
"fogColor":"140,140,140"
},
{
"biomeName":"Underworld",
"dust":false,
"dustColor":"0,0,0",
"fog":true,
"fogDensity":0.40,
"fogColor":"150,140,140"
}
],
"blocks":[
],
"dimensions":[
],
"footsteps":{
},
"forgeMappings":[
]
}

this works perfectly fine on version DynamicSurroundings-1.10.2-3.4.7.2 but not the newest one dunno why lol, note im still using 1.10.2 version

commented

Check your client log to see if there is an exception.

EDIT: If there is no exception try changing the "biomeName" tag to a "conditions" tag:

"conditions": "biome.name == 'Northrend'"

and

"conditions": "biome.name == 'Underworld'"

I don't recall changing anything in the matching code but I cannot rule out a regression. I have not checked into the code as of yet (RL things going on) but I will check as soon as I can.

commented

this was changed when u did some changes with fog system way back lol
but ill test in few days been working 60 hours a week lol

commented

Following up. It does appear I removed "biomeName" support in favor of the condition approach. Making the above changes should help. :)

commented

{
"biomes":[
{
"conditions": "biome.name == 'Northrend'"
"dust":false,
"dustColor":"255,255,255",
"fog":true,
"fogDensity":0.40,
"fogColor":"140,140,140"
},
{
"conditions": "biome.name == 'Underworld'"
"dust":false,
"dustColor":"0,0,0",
"fog":true,
"fogDensity":0.40,
"fogColor":"150,140,140"
}
],
"blocks":[
],
"dimensions":[
],
"footsteps":{
},
"forgeMappings":[
]
}

doesnt work still see blue fog in overworld and red fog in nether
heres my script if u wanna do some testing and paste in what u got working.

also wanted to ask about sun/moon about hiding them so fog looks real lol

commented

It appears you are missing commas at the end of your condition entries. A nifty website to help check the JSON is www.jsonlint.com

commented

any update lol?

commented

thanks for the fix.

commented

Closing out as resolved. Let me know if you run into any other issues.