Serene seasoins bug
DrakeBD opened this issue · 21 comments
Mod Version:
DynamicSurroundings-1.12.2-3.4.10.4
Forge Version:
1.12.2 - 14.23.5.2768
Link to crash log (if applicable):
No crash
Description:
There is no crash here just odd mechanics.
It seem dynamic surroundings is messing with seasons winters and making it so that all Plains type biomes have constant snow laying on the ground even when it is not winter for example in spring it started raining but snow was settling on the ground even though it was not snowing changing the season to winter did change the rain to snow and when changing back to spring snow turned to rain but snow on the ground continued to grow and settle.
Other possibility that occurred to me is that it could be a disconnect between the server and client. DS relies on client side SS information so it could be operating off incorrect information. Not saying this is the issue - just spitballing.
I would say it could have been but tested on a server and single player same occurrence but yes not a problem will test again when you push a new update and will let you know if this persists
What version of SS are you using? I know what you have is relatively current - just getting a fix on it because SS has been changing quite a bit.
If snow is accumulating on the ground it means that SS is making that happen. The recent builds of SS it is possible for it to snow even though it is not specifically winter. Snow/ice is tied to temperature now a days and not some sort of biome attribute. Pinging @Forstride for more insight.
(And to make it more complicated temperature is tied to a specific block position. In classic vanilla you can see this by going up elevation in extreme hills while raining and it turns to snow.)
He already submitted the issue to us, but he said that disabling Dynamic Surroundings fixed it. Not really sure how, as I'm pretty sure you guys don't touch the temperature or anything, but who knows.
I also couldn't recreate it myself with just Serene Seasons, so it doesn't seem to be something on our end.
Hmmm.....this is where I calculate the temp for the location. getFloatTemperature() will call BiomeHooks.getFloatTemperature() in a derived class. Where SS is concerned do I need to do all that heightmap stuff, or does the BiomeHooks take care of it? (I'm stretching here a bit to figure out what is going on).
EDIT: This may be the problem. That routine relies on precipitation height, which is the highest block location in the block column that can be hit by rain. I will have to dig.
No, SS handles the height-based temperature stuff in getFloatTemperature, but that shouldn't even be an issue as the Plains biome certainly isn't high enough to get snow outside of winter.
We are putting together a modpack for our community it's in beta so everytime you guys update we push the mod updates so to answer your question I'm using the current released version of SS the biomes subjected to this bug are any biome with plains in it so sunflower plains are also affected by the summer snow settling when it rains
@Forstride I have seen it snow in plains during early spring. :)
@Forstride I have seen it snow in plains during early spring. :)
Me too but not in summer lol
Taigas I have seen it snow late spring IIRC. Haven't seen snow in summer, though. And if you are willing to take it on the chin for BETAs you can update to the next DS BETA. I reworked a lot of stuff, and has better integration with SS as well as season diagnostics. I may be pushing a build in a couple days.
@xkforce You have v3.5.0.2BETA installed. v3.5.0.3BETA is the latest and should work.
The latest versions of both Serene Seasons and Dynamic Surroundings crash if they're together.
Do you have crystal chests by chance?
It's what I thought. I will have a fix posted shortly. Gotta love mod interactions.
Yeah have iron chests mod i figured the log reference that mod but also mentioned dynamic surrounding too and as i changed no other mod other than this one figured it was related so posted here 💃
OK. v3.5.0.5 is up. And I double checked it with iron chests. :)
Ok ill test it now and get back to you
@OreCruncher Good news all bugs fixed snow now melts in summer and no crashes on RTP commands
Yay! Thanks for dogging this for me. Let me know if you see any other weirdness.
Yay! Thanks for dogging this for me. Let me know if you see any other weirdness.
Your most welcome and will do 💃
Pushed v.3.5.0.4 to CurseForge. Give it a try and let me know if the problem resolves. If not, enable Dynamic Surroundings debug tracing and take a screenshot. It will have some information in yellow on the left side of the debug HUD that may have some clues.
Pushed v.3.5.0.4 to CurseForge. Give it a try and let me know if the problem resolves. If not, enable Dynamic Surroundings debug tracing and take a screenshot. It will have some information in yellow on the left side of the debug HUD that may have some clues.
Well thanks for pushing the new version but now the game wont even load crashes on start here is the logs
crash-2018-12-04_15.04.01-client.txt
latest.log
no other mod has changed appart from Orelib and DynamicSurroundings.