1.12.2 Crash when trying to load into world
yanphi opened this issue · 23 comments
Mod Version:
DynamicSurroundings-1.12.2-3.4.10.5.jar
Forge Version:
forge-14.23.5.2768
Link to crash log (if applicable):
https://paste.dimdev.org/uyuyosehus.mccrash (Single Player)
https://paste.dimdev.org/ukavusayed.mccrash (Multiplayer)
Description:
Not sure if there's any difference between multiplayer or singleplayer. But I'm crashing ever time I try to load into the world. I had experienced the problem before, but after restarting the game and transferring the file from my server over to SP, the problem had subsequently stopped. But after login in a while later, the problem persists and what I had tried earlier stopped working.
Can you update to at least Forge 2779 and see if the problem persists?
EDIT: Also, check the 1.12.2 folder under "mods" to see if there is a dynamic surroundings JAR. If there is one delete it.
I'm playing the game on 2 computers as I move between 2 locations, so when I got home and started playing on that one, I had no problem loading into the server. I now believe there was something wrong with the files on my other computer.
And did you mean something like this?
That should be the mods folder. There may be a folder in there at the top named "1.12.2". Check inside that for the DS core mod.
Just checked, the file doesn't seem to be there.
I'm playing from a modpack and when I was looking, I saw that there were also a few people who have encountered the problem as well.
If you scroll down and look in the comments, a few people have posted a link to the crash report, but it isn't detailed with version numbers and such.
https://www.curseforge.com/minecraft/modpacks/roguelike-adventures-and-dungeons
I vaguely recall a client side dependency issue that I fixed around that time frame. Unfortunately I am not sure what version of DS they were referring to. I loaded up the 3.4.10.5 version in my test environment and did not have any crashes that fit that description.
Would you have a client log from the time of the crash? I want to look at the init process to see if anything strange is going on.
EDIT: Also how often does this crash occur? I loaded up the pack and haven't been able to repro as of yet.
EDIT2: When the crash happened with the server, the crash was client side, not server side?
Then I am going to need a client side log. Usually "class not found" means that an ASM transform blew a gasket and most of the time I can find evidence in the log.
https://paste.dimdev.org/hufofadeti.mccrash
This is a client side log.
@agentwolf88 That is the same error as 434. This one is different. It is complaining about the ClientRegistry class not being found.
@agentwolf88 Can you post a link to your client log to issue #434?
https://drive.google.com/file/d/15yDvxfUSvhJoIwgVpfENwitJzcNfe8nJ/view?usp=sharing
i hope this is the right log
Sorry yes, I realised that this was a client side crash. The server didn't have any problems, but the links I posted earlier was of trying to connect to the server and trying to play locally.
I've tried playing the game again just then and it crashed on my other computer (the one which I didn't have any problems initially.)
Here is a link to my client log: https://pastebin.com/4jUDDX8F
OK. Here is the real culprit:
Caused by: java.lang.IllegalArgumentException: Cannot add types to unregistered biome net.minecraft.world.biome.BiomeMushroomIsland@1c66cd02
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:191)
at net.minecraftforge.common.BiomeDictionary.addTypes(BiomeDictionary.java:185)
at net.minecraftforge.common.BiomeDictionary.makeBestGuess(BiomeDictionary.java:285)
at net.minecraftforge.common.BiomeDictionary.ensureHasTypes(BiomeDictionary.java:382)
at net.minecraftforge.common.BiomeDictionary.getTypes(BiomeDictionary.java:217)
at org.blockartistry.lib.BiomeUtils.getBiomeTypes(BiomeUtils.java:104)
at org.blockartistry.DynSurround.registry.BiomeHandler.<init>(BiomeHandler.java:55)
at org.blockartistry.DynSurround.registry.BiomeRegistry.register(BiomeRegistry.java:97)
at org.blockartistry.DynSurround.registry.BiomeRegistry.lambda$init$0(BiomeRegistry.java:119)
at org.blockartistry.DynSurround.registry.BiomeRegistry$$Lambda$2083/1289289873.accept(Unknown Source)
at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:408)
at org.blockartistry.DynSurround.registry.BiomeRegistry.init(BiomeRegistry.java:119)
at org.blockartistry.DynSurround.registry.RegistryManager$$Lambda$2082/256369716.accept(Unknown Source)
at java.util.ArrayList.forEach(ArrayList.java:1249)
at org.blockartistry.DynSurround.registry.RegistryManager.reload(RegistryManager.java:155)
at org.blockartistry.DynSurround.client.ClientRegistry.<clinit>(ClientRegistry.java:81)
... 20 more
And I can tell you right now it's not making sense. It's complaining that a biome cannot be found in the Forge biome registry, but that is where DS got the biome reference to begin with. :\
EDIT: Do you know if Mushroom Islands have been removed?
They shouldn't be? I've realised I have this problem after logging off the server and when I try to login later (such as now) , it doesn't work.
OK. Think it is related to OTG. I am patching DS to handle the exception more gracefully.
Alright so I'm now constantly crashing and I don't know what to do in that world anymore. I believe it's still the same unregistered biome crash, now it's for the ocean?
https://paste.dimdev.org/dobamepomi.mccrash - Dynamic Surrounds Crash log
https://paste.dimdev.org/wocuvitovi.md - Client Crashlog
It's possible. The reason that it may be OTG related is because of how it handles biome registrations. Normally for Vanilla biomes are registered when starting up Minecraft. Because of how OTG works it needs to dynamically change biome when a world actually loads. This can throw things off with Dynamic Surroundings. I have patched in code over the years to address some of the side effects of OTG biome behavior - this appears to be another.