Dynamic Surroundings

Dynamic Surroundings

51M Downloads

[Bug/Issue] Nether ambient sounds playing in all non-vanilla biomes/dimensions.

Raithion opened this issue ยท 3 comments

commented

Mod Version:

3.5.4.3

Forge Version:

14.23.5.2836

Description:
With AbyssalCraft (version 1.9.8) installed, the sound "dsurround:dimension.nether" plays in every non-vanilla biome. This includes all biomes from Biomes O'Plenty, as well as biomes from other dimensions. Aether II, Twilight Forest, Tropicraft, The Beneath, and The Betweenlands are all affected.

Vanilla biomes are unaffected by this issue, and play their intended ambient sounds. Upon uninstalling AbyssalCraft, the issue is fixed and all mod-added biomes and dimensions play their intended ambient sounds again.

I also found that disabling "dsurround:dimension.nether" in the mod options DOES in fact fix the nether's sound from playing... but it also results in all those biomes being dead silent with no ambience at all.

My guess would be this is some kind of integration issue. Regardless, it's incredibly annoying hearing this howling sound everywhere I go, and I hope a fix is able to be found. Others are having the same issue on the CurseForge mod page.

commented

One more report:
#448

commented

It is a bug in the config file I think. It's a regression from when I refactored the internal expression engine.

EDIT: I am also making a change to OreLib for when a bad expression happens. In a nutshell since the expression was bad, a boolean conversion of that result would be true thus the sound would always play. I am changing the expression engine to handle boolean conversions of strings differently.

commented

Pushed 1.12.2-v3.5.5.0 to CurseForge.