Dynamic Surroundings

Dynamic Surroundings

51M Downloads

auroras cause shaders to bug

0Navis0 opened this issue ยท 18 comments

commented

When an aurora is around, if a shader is used, whatever the one which is used, it becomes totally crazy and has multiple displaying bugs until the aurora disappear or the player gets enough away of it. Here is the small video example with BSL Shader.
https://www.youtube.com/watch?v=gF3Tte9T1wg

commented

Which version of DS? Also, auroras don't work well with the advanced shader packs because the packs want to rule the Minecraft world and stomp other rendering. See [#68].

commented

I use the last one, but any of them still causes the same problem.

commented

I dont think this is an OptiFine issue. I use optifine with the internal shaders. And there are some smaller shader packs that work fine.

commented

Yeah but you, optifine devs, and shader devs reject the fault on the others, and in final nothing advance.

commented

I cant help to much if a shader stomps on my sky rendering. :)

commented

Are there any errors/warnings in the error log (game output)?

commented

In this particular case not sure. But in my travels with other shaders nothing shows up in the log. The aurora in DS was at one time rendered during the weather render phase, but has move to a RenderWorldLast event handler in one of the more recent builds.

EDIT: If anyone is interested Aurora render code is here. At some point I was planning to take a look at the blending to see if it could be tweaked to work better.

commented

The Forge WorldProvider can use a custom SkyRenderer for special effects.

commented

Right - can only have 1 sky renderer though. I've been tripping over mods that hook the sky or weather renderer and the auroras won't display, or the reverse - DS wins the race to hook and another mods feature stops working. Would be nice if multiple renders could be registered.

commented

A pre/post-render sky events could be enough

commented

The question is I have is whether it will address this particular issue.

commented

Didn't find any render sky event hooks. :\

commented

OptiFine has no problem with Auroras. It the shader packs. :) The underlying rendering code didn't change. With the most recent release the aurora is positioned at chunk view distance and can't be approached like previous versions. They stay at that distance in the northerly sky. Also, the band is larger with the base being at seal level and stretching up into the sky (height based on chunk render view distance).

commented

It seems to have, Opitfine causes some displaying issues when an aurora appears.

commented

Which version of OF are you running?

commented

@Hypsellis I found the problem. I rearranged the aurora rendering yet again. :) Fix will be in the next BETA. Unfortunately it does not address the broader issue of shader pack compatibility (such as SUES). The aurora still render's gray at a distance because of the shader pack.

commented

It still doesn't work. The auroras still causes Optifine and shaders to become crazy. :(
I don't know if it's normal too, but auroras now appears far from the player, and can't be more approached, they always go away when trying to approach.

commented

Pushed a v3.4.3.0 version with the fix for non-shader OptiFine rendering. Going to use issue [#68] for tracking the generic "gray render" issue w/shader packs.