Dynamic Trim

Dynamic Trim

7M Downloads

Biomes o' Plenty trim materials produce no/missing texture

DJBaphomet opened this issue · 3 comments

commented

Biomes o' Plenty allows you to apply 'Glowworm Silk' and 'Rose Quartz Chunk' as materials for a trim's palette.
Normally, they have no trimmed armour texture in BoP + Vanilla, which I was hoping this mod could fix, however it doesn't seem to do so.
image

BoP does have a resource pack available to fix this though with vanilla, which works well on its own.
image

However, with the mod enabled, this causes all the BoP trim materials to turn the armour pieces into missing textures. The normal vanilla materials function fine, but it makes the problem with BoP's trim materials even worse than they were originally
image

This means that you can't use this mod with Biomes o' Plenty's trim materials with the resource pack that's meant to fix BoP's problem, and either have to skip out on using this mod, or deal with armour not appearing as trimmed in your inventory if you wanna use BoP's materials

Hoping for this mod to support Biomes o' Plenty's trim materials so that the resourcepack isn't needed!

Edit to the main post!
Forstride looked at the log in my reply below and mentioned that replacing the first section of the blocks.json file in the Resourcepack with the first part of Dynamic Trim's blocks.json (the part above "palette_key" line) could fix the problem with the resourcepack

And, after editing the blocks.json, it works just fine!
image

I'm gonna have this issue stand for now, so people can find a solution to the incompat, and also stay as a suggestion for built-in compat for Dynamic Trims to support BoP's trim materials by itself

commented

Should note: Reported and linked this in Biomes o' Plenty's discord, so they know as well
Fortstride reminded me I could probably see what was going on in the log, so here's that too
https://mclo.gs/5k2xsDJ

commented

I will look into dynamically modifying loaded block atlases for trim permutations to move over to a group permutation to allow for Dynamic Trims to be compatible with mods that add other materials.

commented
Screenshot 2024-01-10 at 3 02 48 PM Screenshot 2024-01-10 at 3 02 58 PM

No edits were made to the resource pack and it works now. The resource pack is still needed because of how Mojang implemented trims but at least it works as intended w/ this mod now.

The Implementation
BlocksAtlas atlas = JsonHelper.fromJson(original, BlocksAtlas.class);
atlas.getPalettedPermutationsSource("trims/color_palettes/trim_palette").ifPresent(source -> atlas.addSource(
        source.copy()
              .withType("group_permutations")
              .withDirectories(List.of(
                      "trims/items/helmet",
                      "trims/items/chestplate",
                      "trims/items/leggings",
                      "trims/items/boots"
              ))
              .withTextures(null)
));

Fixed in 1.4.0