Dynamic Trees

Dynamic Trees

25M Downloads

Concurrent modification exception during multiple explosions:

Opened this issue ยท 3 comments

commented

Describe the bug
Breaking dynamic trees and pushing tree branches around midair using multiple explosions at once causes crash if there is too many explosion rays being applied.

To Reproduce
Steps to reproduce the behavior:
Plant multiple (near hundreds) vanilla TNT blocks around a patch of dynamic trees and chain-detonate them. Or download Spartan Weapons and throw multiple dynamite sticks. Or download Cyclic and use Dynamite IV on the patch of trees. Or download ICBM mod and ignite multiple explosive blocks. these modded explosives take less amount of detonations to trigger. This bug is common but doesn't always occur; perform this action again and again until it eventually triggers. will occur best with very large dynamic trees in bunches.

Screenshots
It closes the server before the client crashes, indicating your physics logic is faulting.

Rendering Glitches
Optifine is installed. Required for Vivecraft compatibility of my modpack's development. Rendering does not fault; physics logic is the issue here.

Crashes
forge version 14.23.5.2584 (latest and last)
1.12.2 Dynamic Trees version 0.9.14
1.12.2. Dynamic Trees Biomes o Plenty and Pam's Harvest craft are installed as well (path trace proves this is irrelevant.)

Mods List
WARNING: my modpack is extremely large, however you should be able to notice this crash is the fault of dynamic trees alone caused by vanilla explosion physics.

crash-2020-09-17_13.54.47-server.txt

commented

I hope to see this fixed soon as Dynamic Trees has helped my modpack stay true to its cause.

commented

273cb0f this probably didn't actually fix the problem then, because either the set and/or the stream is not concurrent, rather than the map.

commented

I think I need to redo the filter algorithm such that it doesn't redefine the entire map object on cleanup.