Dynmap-Forge/Fabric

Dynmap-Forge/Fabric

888k Downloads

Support Datapack water and grass colors

galacticwarrior9 opened this issue ยท 9 comments

commented

Issue Description:

Dynmap does not support water and grass colors defined by datapacks, even if they are identical to vanilla values.

(!) Datapack with which the screenshots below were taken (1.17.1) - biomes.zip

The "vanilla values" I will reference are taken from the vanilla worldgen datapack. The datapack linked above is simply a modified version of this. No "new biomes", dimensions or anything of that sort, just colour modifications to existing ones.

Water in biomes will appear white. The image below is of a Warm Ocean biome where water_color is identical to the vanilla value; only water_fog_color has been modified. However, the issue persists even if both values are identical to their vanilla counterparts.] In the image below, not all of the biome was re-rendered after the datapack was added, which is why some parts of it look normal.
Screenshot

Similarly, grass will appear green, regardless of its colour ingame or if it differs from its vanilla value.

Here's an example - a Desert biome:

Screenshot

And here's the same area from ingame:

Screenshot

  • Dynmap Version: Dynmap v3.2-beta-2
  • Server Version: Purpur Build 1287
  • Pastebin of Configuration.txt: Link
  • I have looked at all other issues and this is not a duplicate
  • I have been able to replicate this
commented

I have the same problem. I used the Caves & Cliffs Prototype Data Pack provided by mojang to create the world. When rendering through dynmap, the water in any biome will appear white, and the grass will turn green without exception.

This is the map I rendered using the Dynmap-3.2-SNAPSHOT-spigot plugin (The latest build version as of the current time):

image

This is the original color of grass and water in those biomes:

image

It seems that this is indeed a bug. This map rendering method has caused a lot of trouble to me. If it can be fixed in a future version, I will be very grateful.

commented

Terralith's custom colours don't work for me either, I am on Dynmap v3.2 for Fabric.

commented

I'm having the same issue, with this datapack. All biomes rendering in grayscale. I've found out, however, that the bug only occurs when I have Multiverse installed. If I disable multiverse, the biome coloration works properly and renders correctly. Anyone else getting the same result?

commented

I'm having the same issue, with this datapack. All biomes rendering in grayscale. I've found out, however, that the bug only occurs when I have Multiverse installed. If I disable multiverse, the biome coloration works properly and renders correctly. Anyone else getting the same result?

yes, I'm using terralith datapack, with Dynmap v3.2-beta-3-514, paper 1.17.1 and multiverse installed also
my map: http://map.tatomc.com
datapack terralith: https://www.planetminecraft.com/data-pack/terralith-overworld-evolved-100-biomes-caves-and-more/

commented

Currently experiencing this same issue using the Terralith datapack. I'm using the most recent version of Dynmap (v3.2.1) on Paper.

commented

Experiencing this with a tall map (i.e., a datapack just modifying world height) on 1.17.1 using Dynmap v3.2.1 on Paper.

commented

Would also like to see this supported. Hopefully it isn't too complicated and quick & easy to implement. Experiencing the same problem with custom colors not properly displaying on the map. Grass, water, and tree biome colors all not being used.

Paper dev 73 (Spigot 1.18.1)
dynmap 3.3-SNAPSHOT-578
Terralith v2.0.4

In-game
link

Map render
link2

commented

I'm looking at locking the conversation on this one - additional screenshots and 'yes please' isn't helping. If you have new info (or offers to help) please hit us up in the Discord.

Note; this is different from configuring a rendering and texturepacks/ in Dynmap for rendering.

Unfortunately this is not trivial to impliment. At a guess, it might take someone figuring out why vanilla Minecraft is not providing the correct colour (or collect it better from the code side), or something similar to DynmapBlockScan to create models and recognize colours.

commented

Added to the megathread #3461