Dynmap-Forge/Fabric

Dynmap-Forge/Fabric

888k Downloads

Custom S3 URLs

untuned opened this issue · 7 comments

commented

Feature Description: Allow setting a custom S3 URL in case someone is using a self-hosted solution, an example of this would be MinIO.

  • Additional context: Easier in case I don't want to pay the associated fees, or want to update faster than normal without having to worry about API call costs.
commented

This is standard in pretty much any software that handles S3 connections, you are allowed to set up custom URLs so that you can connect your own cloud provider's S3 compatible software (eg the ones in GCP, Azure, Wasabi, Linode, Vultr...)

commented

dynmap/DynmapCore/src/main/java/org/dynmap/storage/aws_s3/AWSS3MapStorage.java is the problem.
The s3 lite dependency they use does not support other endpoints.
Thus, to support other S3-compatitable services, they need to find an alternative library or rewrite by themselves.
If you do need to save files through it now, mount the bucket to your local directory.

commented

Update on this: there's an s3rework branch that eliminates the s3-lite dependency and supports custom URLs. I hate to ping unnecessarily but @mikeprimm how much of a priority is this for you right now? I don't mean to put pressure but I would also very much enjoy using my MinIO server for Dynmap :)

commented

Hey! Sorry, I deleted my original comment because I also realised that. The S3 version of the library that is hosted here https://repo.mikeprimm.com/io/github/linktosriram/s3-lite-http-client-url-connection/ simply doesn't have the of method, who knows why.

However, probably using another, more up-to-date library is better than trying to patch the current one.

commented
commented

Any ETA when this s3 rework is finished? I would like to use MinIO as well.

commented

I also support this update/change. I would like to use Backblaze/cloudflare.