Dynmap-Forge/Fabric

Dynmap-Forge/Fabric

888k Downloads

us.dynmap:spigot is missing from Maven repository

Sytm opened this issue ยท 5 comments

commented

To build my plugin which uses Dynmap as an optional component I need to have the us.dynmap:spigot:VERSION:unshaded artifact in my classpath so I can get an instance of the Dynmap API, but us.dynmap:spigot is completely missing in the repository.

Alternatively consider using the Bukkit Service Provider API so you can grab a Dynmap API instance without the full platform build.

commented

Heya! Do you mind providing a screenshot or upload of where that reference is used so the guys can make comment? And, if you use gradle, the gradle reference? (sorry if that is off the mark)

I'm pretty sure that the API is working, so it just might be something trivial.

commented

I used it in this line here.

Or is there any other way of getting an API instance?

commented

Including the concrete class defeats the point of an interface-based API contract. Here's an example of the right way to do it:

https://github.com/webbukkit/Dynmap-EssentialsX/blob/master/src/main/java/org/dynmap/essentialsx/DynmapEssentialsXPlugin.java#L394

Yeah that solves it.

Additionally the way it is done should also appear somewhere in the wiki of this repository

commented

Additionally the way it is done should also appear somewhere in the wiki of this repository

The wiki is editable - where were you looking, and what would you suggest?

commented

Including the concrete class defeats the point of an interface-based API contract. Here's an example of the right way to do it:

https://github.com/webbukkit/Dynmap-EssentialsX/blob/master/src/main/java/org/dynmap/essentialsx/DynmapEssentialsXPlugin.java#L394