Dynmap-Forge/Fabric

Dynmap-Forge/Fabric

888k Downloads

Hidden Style not working

pomtom44 opened this issue ยท 17 comments

commented

template is bold
sample data is italicized

Issue Description: Trying to hide a section of the map, hidden limits has worked, but hidden style isnt working. Map just generates as black in that area, no matter what the hidden style is set to

  • Dynmap Version: 3.3-beta-2-570

  • Server Version: Forge-1.12.2-14.23.5.2859

  • Pastebin of Configuration.txt: https://pastebin.com/5SETL3z2

  • Server Host (if applicable): Self

  • Other Relevant Data/Screenshots:
    Generated before putting hidden section in
    https://imgur.com/Bhpexxt
    Generated after putting hidden section in
    https://imgur.com/AqW93Eh

  • Steps to Replicate:
    Generate map
    Edit config to have hiddenlimits
    regenerate map (didnt delete tiles, just did a /dynmap fullrender)

[ Y] I have looked at all other issues and this is not a duplicate
[ Y] I have been able to replicate this

commented

That is what hiddenlimits do, I don't see a bug / issue here

commented

That is what hiddenlimits do, I don't see a bug / issue here

Im not talking about hidden limits, im talking about hide style

Reading though the wiki it says you can change the style of the hidden area to be stone or ocean
https://github.com/webbukkit/dynmap/wiki/World-and-template-settings

hidestyle : If the visibilitylimits and/or hiddenlimits settings have restricted the visible areas of a world, the hidestyle setting is used to control how the chunks of map data being hidden are presented. 3 settings are supported: stone, which causes a stone plain to fill the hidden areas; ocean, which causes a deep ocean to fill the hidden areas; or air, which causes the hidden area to be empty (like the edge of the generated portion of the world map). The default value is stone.

From what im reading, its using the air setting, even though default is stone, and my config is set to ocean

commented

Just tested in latest dynmap (3.4-beta-3) on forge, stone seems to work.
image
ocean works too:
image
air works as supposed to too:
image

commented

yep, github only has releases, not betas

commented

oh 3.4 isnt showing on github?
only shows 3.3 for me
had to find 3.4 from curseforge so will give that a go now

commented

Nope, updated to 3.4 and still having the same issue
Running Dynmap-3.4-beta-3-forge-1.12.2
forge-1.12.2-14.23.5.2859

No other mods and basic config

what are you using for your one to work?

commented

I am using the 1.18.2 forge latest version (don't know the exact one as I am on my phone rn)

Can you send the output of /dmap maplist world?

commented

Could it be an issue with 1.12.2 forge? as we are using that rather than 1.18

commented

I would have to test that but don't have much time this weekend, can you maybe test in 1.18.2 with the same config wether it works or not?

commented

Will do soon (a few hours or so) and update you

commented

@pomtom44 did it work for you?

commented

Hi, sorry yes
1.18.2 worked fine and shows ocean on the marked area

commented

Then test wether 3.4-beta-3 works on your version and if so, you can go ahead and close this issue

commented

I already did
I was testing with 3.4 beta 3 on 1.12.2

Nope, updated to 3.4 and still having the same issue Running Dynmap-3.4-beta-3-forge-1.12.2 forge-1.12.2-14.23.5.2859

No other mods and basic config

commented

that's odd, @mikeprimm in short, on 1.12.2 the hidestyle on lates dynmap doesn't work, but in 1.18.2 it does. Can you fit in time to look at this?

commented

I will just say its not an issue if you dont have time to investigate
the black square works just as well for what im doing, just would look nicer with the water for the area i want to hide
I do understand 1.12 is very old, and mostly un supported now,
Just still wanted to file a report if it was something you wanted to know about

commented

1.12.2 is no longer supported, so unless this issue is present in 1.14.4 or higher it is no longer relevant, closing this issue.