EasierVillagerTrading

EasierVillagerTrading

4M Downloads

Crash with Infinite Trading

Pengu-Hunter opened this issue ยท 5 comments

commented

Information

Minecraft version: 1.12.2
Forge version: 14.23.5.2854
Environment: Singleplayer

Mod name: Infinite Trade and EasierVillagerTrade
Mod version: 1.0 and 1.3

Description

Trying to trade with any villager vanilla or modded crashes the game I'm not sure which of the two mods is the source of the crash.

Crash report

crash-2020-04-30_15.32.25-client.txt

commented

Thanks for a bug report that includes all relevant information, most people seem to be unable to get this right!

The direct cause of the crash is in Infinite Trading, from the stack trace:

java.lang.NullPointerException: Rendering screen
	at com.natamus.infinitetrading.events.VillagerEvent.onVillagerTrade(VillagerEvent.java:15)

but of course it's possible that I'm changing things (replacing the default trading screen with my own) so Infinite Trading's assumptions get broken, leading to this.

Unfortunately, the maker of Infinite Trading doesn't provide source code, so I'm unable to investigate this further.

commented

I found a bug, which I hopefully just fixed. On the other page, you say you found a different mod, but I'd still be interested if the version at https://github.com/gbl/EasierVillagerTrading/releases/tag/1.3.1 fixes the problem for you.

commented

Thank you for the reply and compliment I will consider this issue closed and continue on the Infinite Trading issue page.

Regards Pengu

commented

Sorry I didn't get back to you yesterday about the updated version of your mod but I have tried it and it works, thank you very much.

Regards Pengu

commented

Amendment, it works and opening the trade interface doesn't crash the game anymore but after a certain number of trades the villager locks up ALL trades and items meant to unlock trades don't work the villager being captured and released from entity holding items also won't reset the problem.
To duplicate this install easierVillagertrading 1.3.1 and Infinite trading then trade one inventories worth of the same item in one transaction exit then reenter the trade interface and all trades should be locked.