Easy Mob Farm

Easy Mob Farm

2M Downloads

[Bug] Bonus loot configs does not seem to work

bayi opened this issue · 21 comments

commented

Minecraft and Mod version 🐞
Minecraft: 1.20.1
Mod Loader: Forge
Mod: easy_mob_farm-forge-1.20.1-9.6.0.jar
Extra related mod: Naturalist 4.0.3

Describe the bug 🐞
I added the duck eggs from the Naturalist mod to the bonus loot for the Plains Farms in the mob_farm_bonus.cfg. I see them loaded in the logs, but in the game the bonus drop is not showing up and also after AFKing for 1hour+ next to farm no extra items were dropped.

To Reproduce ⚙️
Steps to reproduce the behavior:

  1. Added this at the end of the config/easy_mob_farm/mob_farm_bonus.cfg:
animal_plains_farm\:\:0\:\:naturalist\:duck=naturalist\:duck_egg\:\:1\:\:20
animal_plains_farm\:\:1\:\:naturalist\:duck=naturalist\:duck_egg\:\:1\:\:15
animal_plains_farm\:\:2\:\:naturalist\:duck=naturalist\:duck_egg\:\:1\:\:10
animal_plains_farm\:\:3\:\:naturalist\:duck=naturalist\:duck_egg\:\:1\:\:5
  1. Put a captured naturalist:duck inside a Plains Mob Farm
  2. No extra loot (Duck egg) is dropped

Expected behavior ✔️
Duck eggs to drop as extra loot and displayed in the tooltip.

Screenshots 📸

Image

Debugging 🛠️
The debug command was not working for me, but i attach the relevant log from latest.log here:

[19márc.2025 18:10:27.147] [modloading-worker-0/INFO] [Easy Mob Farm/]: [Config]  Mob Farm Bonus Configuration

 This configuration file allows you to define the bonus drops for the Mob Farms.

The format is as follows:
- <mob_farm_name>::<tier_level>::<entity_type> = <item_name>::<amount>::<chance 1 of x>

Example:
- bee_hive_farm::0::minecraft:bee = minecraft:honeycomb::1::20
- bee_hive_farm::1::minecraft:bee = minecraft:honeycomb::1::15
- bee_hive_farm::2::minecraft:bee = minecraft:honeycomb::1::10
- bee_hive_farm::3::minecraft:bee = minecraft:honeycomb::1::5

To disable a bonus drop for a default definition, set the amount to 0.

 is up to date: {swamp_farm::1::minecraft:witch=minecraft:redstone::1::15, animal_plains_farm::3::minecraft:sheep=minecraft:white_wool::1::5, monster_plains_cave_farm::1::minecraft:zombie=minecraft:rotten_flesh::1::15, ocean_farm::2::minecraft:squid=minecraft:ink_sac::1::10, nether_fortress_farm::0::minecraft:blaze=minecraft:blaze_rod::1::20, iron_golem_farm::0::minecraft:iron_golem=minecraft:iron_ingot::1::20, ocean_farm::2::minecraft:cod=minecraft:cod::1::10, jungle_farm::1::minecraft:parrot=minecraft:feather::1::15, swamp_farm::2::minecraft:witch=minecraft:redstone::1::10, ocean_farm::1::minecraft:squid=minecraft:ink_sac::1::15, jungle_farm::1::minecraft:panda=minecraft:bamboo::1::15, swamp_farm::0::minecraft:frog=minecraft:slime_ball::1::20, animal_plains_farm::2::minecraft:sheep=minecraft:white_wool::1::10, animal_plains_farm::3::minecraft:chicken=minecraft:egg::1::5, animal_plains_farm::1::minecraft:sheep=minecraft:white_wool::1::15, iron_golem_farm::1::minecraft:iron_golem=minecraft:iron_ingot::1::15, swamp_farm::3::minecraft:frog=minecraft:slime_ball::1::5, nether_fortress_farm::1::minecraft:blaze=minecraft:blaze_rod::1::15, bee_hive_farm::2::minecraft:bee=minecraft:honeycomb::1::10, desert_farm::1::minecraft:husk=minecraft:sand::1::15, jungle_farm::0::minecraft:panda=minecraft:bamboo::1::20, nether_fortress_farm::0::minecraft:magma_cube=minecraft:magma_cream::1::20, jungle_farm::2::minecraft:parrot=minecraft:feather::1::10, swamp_farm::2::minecraft:frog=minecraft:slime_ball::1::10, animal_plains_farm::0::minecraft:chicken=minecraft:egg::1::20, nether_fortress_farm::3::minecraft:blaze=minecraft:blaze_rod::1::5, animal_plains_farm::1::minecraft:chicken=minecraft:egg::1::15, ocean_farm::0::minecraft:squid=minecraft:ink_sac::1::20, animal_plains_farm::1::minecraft:cow=minecraft:leather::1::15, ocean_farm::0::minecraft:cod=minecraft:cod::1::20, desert_farm::0::minecraft:husk=minecraft:sand::1::20, animal_plains_farm::3::naturalist:duck=naturalist:duck_egg::1::5, monster_plains_cave_farm::0::minecraft:zombie=minecraft:rotten_flesh::1::20, desert_farm::3::minecraft:husk=minecraft:sand::1::5, desert_farm::2::minecraft:rabbit=minecraft:rabbit_hide::1::10, animal_plains_farm::2::minecraft:cow=minecraft:leather::1::10, jungle_farm::3::minecraft:panda=minecraft:bamboo::1::5, ocean_farm::3::minecraft:squid=minecraft:ink_sac::1::5, jungle_farm::3::minecraft:parrot=minecraft:feather::1::5, desert_farm::3::minecraft:rabbit=minecraft:rabbit_hide::1::5, ocean_farm::1::minecraft:cod=minecraft:cod::1::15, ocean_farm::3::minecraft:cod=minecraft:cod::1::5, animal_plains_farm::3::minecraft:cow=minecraft:leather::1::5, nether_fortress_farm::3::minecraft:magma_cube=minecraft:magma_cream::1::5, desert_farm::2::minecraft:husk=minecraft:sand::1::10, animal_plains_farm::0::naturalist:duck=naturalist:duck_egg::1::20, bee_hive_farm::3::minecraft:bee=minecraft:honeycomb::1::5, animal_plains_farm::1::naturalist:duck=naturalist:duck_egg::1::15, swamp_farm::2::minecraft:slime=minecraft:slime_ball::1::10, swamp_farm::1::minecraft:frog=minecraft:slime_ball::1::15, bee_hive_farm::1::minecraft:bee=minecraft:honeycomb::1::15, swamp_farm::0::minecraft:slime=minecraft:slime_ball::1::20, desert_farm::1::minecraft:rabbit=minecraft:rabbit_hide::1::15, animal_plains_farm::0::minecraft:cow=minecraft:leather::1::20, animal_plains_farm::2::minecraft:chicken=minecraft:egg::1::10, swamp_farm::3::minecraft:slime=minecraft:slime_ball::1::5, bee_hive_farm::0::minecraft:bee=minecraft:honeycomb::1::20, jungle_farm::2::minecraft:panda=minecraft:bamboo::1::10, swamp_farm::3::minecraft:witch=minecraft:redstone::1::5, animal_plains_farm::0::minecraft:sheep=minecraft:white_wool::1::20, nether_fortress_farm::2::minecraft:blaze=minecraft:blaze_rod::1::10, nether_fortress_farm::1::minecraft:magma_cube=minecraft:magma_cream::1::15, iron_golem_farm::2::minecraft:iron_golem=minecraft:iron_ingot::1::10, monster_plains_cave_farm::3::minecraft:zombie=minecraft:rotten_flesh::1::5, desert_farm::0::minecraft:rabbit=minecraft:rabbit_hide::1::20, swamp_farm::0::minecraft:witch=minecraft:redstone::1::20, iron_golem_farm::3::minecraft:iron_golem=minecraft:iron_ingot::1::5, monster_plains_cave_farm::2::minecraft:zombie=minecraft:rotten_flesh::1::10, nether_fortress_farm::2::minecraft:magma_cube=minecraft:magma_cream::1::10, animal_plains_farm::2::naturalist:duck=naturalist:duck_egg::1::10, jungle_farm::0::minecraft:parrot=minecraft:feather::1::20, swamp_farm::1::minecraft:slime=minecraft:slime_ball::1::15}
[19márc.2025 18:10:27.148] [modloading-worker-0/INFO] [Easy Mob Farm/]: [Config]  Mob Capture Card Configuration

 This configuration file allows you to define the general settings for the Mob Capture Cards.

 Allow and Deny list
--

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩
Naturalist
I have a bunch of other - unrelated - mods installed but i also tested this with only these 2 installed to eliminate interference.

Additional context 📝

commented

Attaching more screenshots here:

Image

Image

Image

commented

Also i just double checked the item ids from the mod and it seems to be correct:

  • The duck is naturalist:duck
  • The egg is naturalist:duck_egg
commented

Thanks a lot for the report and the detailed explanation!

The config file is working as intended, but it currently performs validation for items and entity types, which is failing for some third-party mods.

The issue stems from the mod loading order. The config file is loaded very early in the process, so when it attempts to validate the items and entity types, other mods may not have registered their content yet.

I’ll adjust the loading order to ensure that other mods have sufficient time to register their items and entity types before the config file is processed.

commented

Do you have any update on this? I'm currently trying to setup custom drops as well and I'm also having trouble.

commented

Image
This is what I tried to make mine, and it's also not working.

commented

Yes! I would really appreciate it if you could! ❤

commented

Here's my log. https://mclo.gs/DsuG8RF

It's now showing its bonus drop, but I will have to AFK for a while to see if it's giving anything else I've added in the config. So far nothing since the past 20 minutes. Image

Thanks for sharing the log and the screenshot!

According to the log, the configured farm has a drop chance of 1 in 6000, which is quite high and makes it unlikely to see any loot within a short period of time:

monster_plains_cave_farm::3::iceandfire:ice_dragon with a chance of 1 of 6000 for 1 dragonegg_silver.

For testing purposes, I recommend using a lower value, such as 1 or 2, to confirm that the bonus drop is working as expected. Once confirmed, you can adjust the value to better balance gameplay.

commented

Thanks for sharing the log and the screenshot!

According to the log, the configured farm has a drop chance of 1 in 6000, which is quite high and makes it unlikely to see any loot within a short period of time:

monster_plains_cave_farm::3::iceandfire:ice_dragon with a chance of 1 of 6000 for 1 dragonegg_silver.

For testing purposes, I recommend using a lower value, such as 1 or 2, to confirm that the bonus drop is working as expected. Once confirmed, you can adjust the value to better balance gameplay.

Thanks for the response! I will try that out. But does this only apply to one type of drop? Because in my config I have set multiple bonus drops for the Ice Dragon, because normally you have to right click their corpse to harvest loot.

commented

latest.log

Full log file attached after a fresh restart, joined the server still no tooltip showing up ( will afk more to test drops too but sofar if the tooltip was not showing it i did not receive any bonus loot either )

LMK if you need anything

Thanks for the log! I’ll try to reproduce the issue on my side using Minecraft 1.20.1.

So far, I’ve only tested this with the Naturalist mod on version 1.18.2, so I’ll verify if the tooltip and bonus drops behave correctly in 1.20.1 as well. I’ll let you know as soon as I have results.

Feel free to share any additional details or findings in the meantime!

commented

Thanks for the response! I will try that out. But does this only apply to one type of drop? Because in my config I have set multiple bonus drops for the Ice Dragon, because normally you have to right click their corpse to harvest loot.

According to the shared log, I only found a single entry for:

monster_plains_cave_farm::3::iceandfire:ice_dragon

This matches the farm and entity shown in your screenshot.

Currently, the bonus drop system supports only one item stack per entity in the config file.
That means multiple bonus drops for the same entity (like the Ice Dragon) won’t work as expected—only one entry will be used, and in most cases, a random one will be selected if there are duplicates.

I’ll look into better integration with Ice and Fire to see if it’s possible to hook into their custom loot handling.

If you'd like support for multiple drops per entity, let me know! I’d be happy to open a separate feature request for this.

commented

Thank you very much also thanks for the fast fix, i just confirmed it working perfectly fine in single and multiplayer !

commented

Image

Image

Mine is still not working... I'm on Fabric.

commented

Sorry, i spoke too soon. On my fabric server it was working but on my forge server it is still not showing the bonus drop ( will afk for a little bit to test if it actual drops or its just a visual tooltip issue )

commented

I've added additional log entries in the latest update for both the client and server sides.

Please make sure that:

  • The same config file is used on both client and server.
  • Both sides are restarted after updating the configuration.

If you're still not seeing any bonus drops after a restart, please double-check your logs and feel free to share them here for review.

The logs will now clearly indicate both successfully added bonus drops and any errors in the configuration.

For example:

[20:07:05] [Server thread/INFO] [Easy Mob Farm/]: [MobFarmBonusConfig] Add jungle_farm::1::minecraft:parrot with a chance of 1 of 15 for 1 feather.
[20:07:05] [Server thread/INFO] [Easy Mob Farm/]: [MobFarmBonusConfig] Add swamp_farm::2::minecraft:witch with a chance of 1 of 10 for 1 redstone.
[20:07:05] [Server thread/INFO] [Easy Mob Farm/]: [MobFarmBonusConfig] Add ocean_farm::1::minecraft:squid with a chance of 1 of 15 for 1 ink_sac.
[20:07:05] [Server thread/INFO] [Easy Mob Farm/]: [MobFarmBonusConfig] Add animal_plains_farm::1::minecraft:cat with a chance of 1 of 20 for 1 diamond.
[20:07:05] [Server thread/INFO] [Easy Mob Farm/]: [MobFarmBonusConfig] Add jungle_farm::1::minecraft:panda with a chance of 1 of 15 for 1 bamboo.
[20:07:05] [Server thread/ERROR] [Easy Mob Farm/]: [MobFarmBonusConfig] Invalid entity type minecraft:frog in config file mob_farm_bonus.cfg

These entries should help you verify which bonuses are correctly registered and identify any misconfigured entity types.

commented

I also retested on fabric too it was working on the first try, after i restarted the server it isnt.

You told above that it was a loader issue maybe it is "random" a little bit, will try and restart my main (forge) server too and see if i am lucky ...

commented

Hi, i am using a shared folder ( synced over NFS ) for my forge server and my client.

It definitely works for the client (singleplayer) but on forge even after multiple restarts i can not see the extra drops in the tooltips and no drops sofar ( afking form 15+ mnutes )

I also checked the logs for any clues you wrote above:

Image

Will restart the server once more and send in the full log file

commented

latest.log

Full log file attached after a fresh restart, joined the server still no tooltip showing up ( will afk more to test drops too but sofar if the tooltip was not showing it i did not receive any bonus loot either )

LMK if you need anything

commented

Here's my log.
https://mclo.gs/DsuG8RF

It's now showing its bonus drop, but I will have to AFK for a while to see if it's giving anything else I've added in the config. So far nothing since the past 20 minutes.
Image

Edit: No item has dropped for the past 50 minutes.

commented

Client Test with Naturalist, works fine:
Image

Server Test with Naturalist, works fine. Client Tooltip is broken:
Image

Based on these tests, it looks like the server is correctly processing the configured drops.
However, the client doesn't seem to display them properly in the tooltips.

I'll investigate this further to determine why the tooltip information isn't showing as expected.

commented

Oooh, i will test this right away ;)

commented

I see you are still working on it, i just pulled your commits and synced it into my fork and built it, uploaded to the forge server ( so i am testing the redstone stuff too :D )

And i have good news:

  • The tooltip shows the bonus loot \o/
  • Drops are there after a few minutes afking

The only downside is now that all my ducks are cooked by default ( see screenshot, forgot to change the locale but the item ids are visible )

Image
Image