Advancements and Recipes don't work as expected

Question

Advancements and Recipes don't work as expected

cringoleg opened this issue 8 months ago · 1 comments

cringoleg commented 8 months ago

Describe the bug

There are problems with parsing advancements Parsing error loading custom advancement see logs below.
For the recipes - see detailed description.

Advancements

The mod's Advancements tab does not appear beforehand, thus requires researching recipes from external sources.
When starting a new game, Advancement tab is not there. After crafting a template farm, this is what we have:

Recipes

After starting the game, the recipe book looks like that:

After getting iron, hopper and glass:

After crafting Iron Farm Template and getting feather, wheat seeds, wheat, egg, 2x grass and white tulip the recipe book is not updated, although the Animal Plains Farm (Iron) is craftable:

All recipes (except from template farms) do not appear, unless farm is crafted.
Here I have manually crafted the Animal Plains Farm (Iron) and searched farm:

Expected behavior

Advancements should be updated as the player's progress moves forward with crafted farms. I.e. after crafting Iron Mob Farm Template there should be new advancements (like in original minecraft advancements) that tell player what to do. In my case a this guideline was missing and I had to research source code and yt for hints.

Recipes should be given to player after they find all necessary materials for the respected recipe.

Logs

[14:22:51] [Render thread/INFO]: Loaded 8 recipes
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_swamp_farm: Expected item to be an item, was unknown string 'easy_mob_farm:swamp_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_desert_farm: Expected item to be an item, was unknown string 'easy_mob_farm:desert_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_monster_plains_cave_farm: Expected item to be an item, was unknown string 'easy_mob_farm:monster_plains_cave_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_jungle_farm: Expected item to be an item, was unknown string 'easy_mob_farm:jungle_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_bee_hive_farm: Expected item to be an item, was unknown string 'easy_mob_farm:bee_hive_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_ocean_farm: Expected item to be an item, was unknown string 'easy_mob_farm:ocean_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_nether_fortress_farm: Expected item to be an item, was unknown string 'easy_mob_farm:nether_fortress_farm'
[14:22:51] [Render thread/ERROR]: Parsing error loading custom advancement easy_mob_farm:crafting/craft_animal_plains_farm: Expected item to be an item, was unknown string 'easy_mob_farm:animal_plains_farm'
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_insect_net: Task Advancement{parentId=easy_mob_farm:crafting/craft_bee_hive_farm, display=net.minecraft.advancements.DisplayInfo@c9cd06e, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_insect_net=net.minecraft.advancements.Criterion@75351aec}, requirements=[[get_insect_net]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_catch_cage: Task Advancement{parentId=easy_mob_farm:crafting/craft_jungle_farm, display=net.minecraft.advancements.DisplayInfo@55af9b48, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_catch_cage=net.minecraft.advancements.Criterion@890196b}, requirements=[[get_catch_cage]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_fishing_net_small: Task Advancement{parentId=easy_mob_farm:crafting/craft_ocean_farm, display=net.minecraft.advancements.DisplayInfo@686a08f4, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_fishing_net_small=net.minecraft.advancements.Criterion@60b90fd3}, requirements=[[get_fishing_net_small]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_witch_bottle: Task Advancement{parentId=easy_mob_farm:crafting/craft_swamp_farm, display=net.minecraft.advancements.DisplayInfo@34ec33f4, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_witch_bottle=net.minecraft.advancements.Criterion@1c83652d}, requirements=[[get_witch_bottle]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_catch_cage_small: Task Advancement{parentId=easy_mob_farm:crafting/craft_desert_farm, display=net.minecraft.advancements.DisplayInfo@3a8dd899, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_catch_cage_small=net.minecraft.advancements.Criterion@3da068e8}, requirements=[[get_catch_cage_small]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_urn_small: Task Advancement{parentId=easy_mob_farm:crafting/craft_monster_plains_cave_farm, display=net.minecraft.advancements.DisplayInfo@2620d0dc, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_urn_small=net.minecraft.advancements.Criterion@18f90bd8}, requirements=[[get_urn_small]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_collar_small: Task Advancement{parentId=easy_mob_farm:crafting/craft_animal_plains_farm, display=net.minecraft.advancements.DisplayInfo@21e441d1, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_collar_small=net.minecraft.advancements.Criterion@711329fe}, requirements=[[get_collar_small]]}
[14:22:51] [Render thread/ERROR]: Couldn't load advancement easy_mob_farm:crafting/craft_fishing_bowl: Task Advancement{parentId=easy_mob_farm:crafting/craft_ocean_farm, display=net.minecraft.advancements.DisplayInfo@342cc706, rewards=AdvancementRewards{experience=0, loot=[], recipes=[], function=net.minecraft.commands.CommandFunction$CacheableFunction@55704859}, criteria={get_fishing_bowl=net.minecraft.advancements.Criterion@5c9844a4}, requirements=[[get_fishing_bowl]]}

Additional context

Minecraft version: 1.19.4
Mod version: 6.6.2

Mod List:

backpacked-forge-1.19.4-2.1.14.jar
balm-forge-1.19.4-6.0.2.jar
cgm-forge-1.19.4-1.3.7.jar
chunkloaders-1.2.8-forge-mc1.19.3.jar
collective-1.19.4-6.66.jar
corpse-1.19.4-1.0.2.jar
easy_mob_farm_1.19.4-6.6.2.jar
enchantmenttransfer-0.0.6-1.19.4.jar
everythingcopper-1.19.4-0.2.2.0.jar
framework-forge-1.19.4-0.6.16.jar
improvedmobs-1.19.4-1.11.5-forge.jar
inventorysorter-22.0.0.jar
jei-1.19.4-forge-13.1.0.16.jar
lootr-1.19.4-0.6.27.65.jar
merenc-forge-1.20.x-v3.2.jar
NaturesCompass-1.19.4-1.11.0-forge.jar
netherportalfix-forge-1.19.4-12.0.1.jar
Stabx_Modern_Guns_v6.3_1.19.4_Final.jar
supermartijn642configlib-1.1.8-forge-mc1.19.jar
supermartijn642corelib-1.1.15-forge-mc1.19.4.jar
tenshilib-1.19.4-1.7.0-forge.jar
treeharvester-1.19.4-8.2.jar
YungsApi-1.19.4-Forge-3.10.1.jar
YungsBetterDungeons-1.19.4-Forge-3.4.0.jar
YungsBetterMineshafts-1.19.4-Forge-3.4.0.jar
YungsBetterOceanMonuments-1.19.4-Forge-2.3.0.jar
YungsBetterStrongholds-1.19.4-Forge-3.4.0.jar
YungsBridges-1.19.4-Forge-3.3.0.jar
YungsExtras-1.19.4-Forge-3.3.0.jar

MarkusBordihn · Answer 1 · 2023-10-19T21:24:26.000Z

First of all thanks for all of the detailed bug / issues reports, they make it easy to understand the issue and to provide a corresponding fix.
I just created a fix for 1.18.2 and will patch and release all other versions in the next hours / day.