Easy NPC

Easy NPC

2M Downloads

[Bug] Crash with Let's Do Brewery

SandFoll opened this issue ยท 12 comments

commented

Game crashes with serious bug

When using the lets do brewery module, pressing the right mouse button on an NPC using the armor and clothes in the module will cause the game to crash. When this bug occurs in the server, it will cause other players to crash at the same time.
B12CF8CF-15F8-4E5A-9669-8D138781C983

commented

Sorry I'm still not able to reproduce the issue, regardless if right-click, left-click or shift-right-click and shift-left-click.

easy_npc_issue_120.mp4

Do you use a mod pack were I could reproduce the issue ?

At the moment I see no hint that the issue is related to this mod.

commented

I got the solution from the lets do module and found that all modules must be updated to the latest version. Sorry for wasting your time. Thank you for answering me patiently!

commented

After the easynpc module is deleted from the server, players whose game crashes due to this bug are still unable to enter the server. Entering again will still cause the game to crash for all players. Even if Minecraft is uninstalled and reinstalled, the crash will still occur.

Please share the corresponding crash log, otherwise I'm unable to help with this.
See: https://github.com/MarkusBordihn/BOs-Easy-NPC/wiki/Debugging#why-debugging-is-essential-%EF%B8%8F%EF%B8%8F

In general the Easy NPC mod is not storing any data to the users and all data are stored inside the NPCs in the world itself.
If you remove the mod the NPCs and their data gets automatically invalid and will be removed from your world.
This means the crashes without the Easy NPC mod for specific players could not be related to this mod.

commented

Thanks for the report.

Please confirm if the same crashes happen with the latest beta and share the corresponding crash-log. Thanks.

Related mod: https://www.curseforge.com/minecraft/mc-mods/lets-do-brewery

commented

After the easynpc module is deleted from the server, players whose game crashes due to this bug are still unable to enter the server. Entering again will still cause the game to crash for all players. Even if Minecraft is uninstalled and reinstalled, the crash will still occur.

commented

If i could jump in really quickly. I recommend restoring your server to a time before the crash happened. You can do that in your server panel and hit restore. If that doesn't work contact your server provider and have them restore it to an earlier time. That should let people join again. Let's do has an issue with breaking a few mods and always recommend backing up your server b4 adding new mods. Hope that helps.

commented

Let me briefly describe what happened. Clicking on an NPC using brewery clothing caused the crash of all players on the server. After I deleted the easynpc module from the server, my friend still crashed when he entered the server. Afterwards, he changed a computer for testing. After the crash, the server still crashed when he used a new computer to enter it. The crash still occurred when deleting the module.
This is the crash report
minecraft-exported-crash-info-2024-03-28T20-53-55.zip
minecraft-exported-logs-2024-03-28T20-54-42.log
@MarkusBordihn

commented

The latest beta version still has this problem

commented

Thanks for the details. I checked the crashlog and the crash is related to the following two mods:

  • letsdo-API (causing the crash)
  • Optifine (crashes as well)
Caused by: java.lang.AbstractMethodError: Receiver class satisfy.candlelight.util.DoAPIImpl does not define or inherit an implementation of the resolved method 'abstract void registerArmor(de.cristelknight.doapi.client.render.feature.CustomArmorManager, net.minecraft.client.model.geom.EntityModelSet)' of interface de.cristelknight.doapi.api.DoApiAPI.
	at de.cristelknight.doapi.client.render.feature.CustomArmorManager.updateArmors(CustomArmorManager.java:64) ~[letsdo-API-forge-1.2.9-forge.jar%23288!/:?]
	at de.cristelknight.doapi.client.render.feature.CustomArmorManager.getModel(CustomArmorManager.java:45) ~[letsdo-API-forge-1.2.9-forge.jar%23288!/:?]
	at de.cristelknight.doapi.client.render.feature.CustomArmorFeatureRenderer.renderArmorPiece(CustomArmorFeatureRenderer.java:50) ~[letsdo-API-forge-1.2.9-forge.jar%23288!/:?]
	at de.cristelknight.doapi.client.render.feature.CustomArmorFeatureRenderer.render(CustomArmorFeatureRenderer.java:39) ~[letsdo-API-forge-1.2.9-forge.jar%23288!/:?]
	at de.cristelknight.doapi.client.render.feature.CustomArmorFeatureRenderer.m_6494_(CustomArmorFeatureRenderer.java:26) ~[letsdo-API-forge-1.2.9-forge.jar%23288!/:?]
	at net.minecraft.client.renderer.entity.LivingEntityRenderer.m_7392_(LivingEntityRenderer.java:215) ~[client-1.20.1-20230612.114412-srg.jar%23332!/:?]
	at net.minecraft.client.renderer.entity.player.PlayerRenderer.m_7392_(PlayerRenderer.java:63) ~[client-1.20.1-20230612.114412-srg.jar%23332!/:?]
	at net.minecraft.client.renderer.entity.player.PlayerRenderer.m_7392_(PlayerRenderer.java:44) ~[client-1.20.1-20230612.114412-srg.jar%23332!/:?]
	at net.minecraft.client.renderer.entity.EntityRenderDispatcher.m_114384_(EntityRenderDispatcher.java:190) ~[client-1.20.1-20230612.114412-srg.jar%23332!/:?]

It's seems that the letsdo-API is using a CustomArmorManager / Rendering which fails on a specific entity and causing the crash on the client.
I will try to reproduce the issue, but as already mentioned the crash is not related to this mod and so only the letsdo-API developer are able to fix them.
You could check the entity at x=223, y=72, z=527 to see if it has any "fancy" configuration or so.
Maybe spawning the player at another position would fix the crashes for them.

It seems there are some crash reports for this mod: https://github.com/Team-Let-s-Do/DoAPI/issues?q=crash

commented

Hmm, I wonder if this affects the 1.19.2 version, too. I know they changed their api in 1.20.1. I will check when I get home. Thanks for the info. I doubt they will fix the issue on my version if it does.

commented

I tried to reproduce the issue and was not really able to reproduce it.

image

The armor is not rendered, but also not crashing my client.

image
commented

Instead of dressing the NPC in the configuration interface, you hold the clothes in your hand and right-click the NPC. @MarkusBordihn