Easy NPC

Easy NPC

2M Downloads

[Bug] NPC isn't executing action with button on different buttons.

DanzlPriv opened this issue ยท 6 comments

commented

Describe the bug ๐Ÿž
Currently I have paired this mod with FTB Quests as I wanted to make an effective questline using the NPCs. This was used via a command called /ftbquests change_progress @initiator complete [QUEST ID]

To Reproduce โš™๏ธ
Give NPC a Questline using FTBQuests on Fabric, and proceed to add the command in the NPCQuests on Forge.

Go through the buttons to make sure it works, and NPC's should theoretically complete the quest based on which buttons you press.

It is quite hit or miss, sometimes it works completely fine with some buttons, while with other buttons, the command doesn't work at all.

Interacting action is fine, and the first button action works every time, but every time afterwards, it just doesn't seem to work.

Expected behavior โœ”๏ธ
Expected to run all commands/actions without any issue.

Screenshots ๐Ÿ“ธ
image

Your Mother... should execute the command and almost finish the quests. But it doesn't execute.

image
But with this other NPC that I have, it does the same thing where with some buttons it works, and others it doesnt.

Debugging ๐Ÿ› ๏ธ
[27.05 14:24:51] [Server] [Netty Epoll Server IO #26/DEBUG]: Try to execute action ActionData [type=COMMAND, cmd=/ftbquests change progress @initiator complete 5EE51E5FC363DC24, permLvl=2, execAsUser=false, debug=false] as entity Humanoid['Big Bully'/30672, l='ServerLevel[losersmc]', x=-75.31, y=63.00, z=-72.64] with owner permission level 3 of max. 4 ...
[27.05 14:24:51] [Server] [Netty Epoll Server IO #26/DEBUG]: Execute Entity Humanoid['Big Bully'/30672, l='ServerLevel[losersmc]', x=-75.31, y=63.00, z=-72.64] Command: "ftbquests change progress DanzlDistressful complete 5EE51E5FC363DC24" with permission level 3
[27.05 14:24:51] [Server] [Netty Epoll Server IO #26/DEBUG]: Trigger action event ActionData [type=COMMAND, cmd=/ftbquests change_progress @initiator complete 341C89B3F72BB0FC, permLvl=2, execAsUser=false, debug=false] for Humanoid['Big Bully'/30672, l='ServerLevel[losersmc]', x=-75.31, y=63.00, z=-72.64] from class_3222['DanzlDistressful'/21381, l='ServerLevel[losersmc]', x=-75.63, y=63.00, z=-71.10] with permission level 2 ...
[27.05 14:24:51] [Server] [Netty Epoll Server IO #26/DEBUG]: Try to execute action ActionData [type=COMMAND, cmd=/ftbquests change_progress @initiator complete 341C89B3F72BB0FC, permLvl=2, execAsUser=false, debug=false] as entity Humanoid['Big Bully'/30672, l='ServerLevel[losersmc]', x=-75.31, y=63.00, z=-72.64] with owner permission level 3 of max. 4 ...
[27.05 14:24:51] [Server] [Netty Epoll Server IO #26/DEBUG]: Execute Entity Humanoid['Big Bully'/30672, l='ServerLevel[losersmc]', x=-75.31, y=63.00, z=-72.64] Command: "ftbquests change_progress DanzlDistressful complete 341C89B3F72BB0FC" with permission level 3

Using FTBQuests alongside it. ๐Ÿงฉ

commented

Thanks for the report. Could you please enable the "Debug" mode for the buttons which are not working and save them again.

image

This will show the result of the execution of the action as well in the logs, which should give you an indicator why this is not working in some cases.
According the log it seems that the commands are executed so I see no issues on the NPC side so far.

commented

After doing that, what should I do next in order to provide you the log? Do I go to my logs in my instance and send that through?

commented

Yes. The logs will show additional entries after the NPC specific ones with the result of the command or in the case the command fail more details why it fails.

For e.g.
image

Results in the following:
image

commented

After importing it over to Fabric, the debugged version of the NPC, it won't let me spawn it in my MC server, the command line just shows as blank.

https://drive.google.com/file/d/1FJAjbQvbjqJNLnUIXwYKH5d9E-UV4miU/view?usp=drive_link

this is the NPC, but it just won't let me spawn him in

commented

Any character with Debug enabled stops me from spawning any NPC in the game from forge to fabric.
image
image
These are all the ones I have had, and no issues so far, but once I turned debug for those two on, it just stopped the usage of commands for importing.

commented

I've made some changes in the latest beta version related to command handling.
Please check if you can still reproduce the issue in beta version 5.5.1. Thanks!