Easy NPC

Easy NPC

2M Downloads

[Crash Report] Character crash due to memory leak

Krampus69 opened this issue · 2 comments

commented

Minecraft and Mod version 🐞
Minecraft 1.20.1
easy_npc-forge-1.20.1-5.7.4

Description of the crash 💥
NPC crashes when it gets highlighted by the wand but you swap to another item quickly

Logs 📝
To speed up the diagnosis, please provide the following files if possible:
latest.log
debug.log
crash-2024-11-14_18.06.54-client.txt

Additional context 📋
NPC seems to have a memory leak linked to Geckolib/Oculus/etc...And Easy NPC.
The character is a slim NPC with a full armor set from the fantasy armors mod
https://www.curseforge.com/minecraft/mc-mods/fantasy-armor

commented

Thank you for the report! Unfortunately, I wasn’t able to reproduce the issue on my end.

This issue doesn’t seem to be directly related to the NPC wand, as the wand only adds a glowing effect to mobs and doesn’t perform any complex rendering.
Here’s the relevant code for reference: EasyNPC Wand Code

According to the logs you shared, it looks like GeckoLib is attempting to render a specific armor, which is causing the crash. I’ll try to reproduce the crash with the Fantasy Armor mod to see if I can pinpoint the issue.
However, please note that this part of the crash—net.minecraft.client.renderer.entity.MobRenderer.m_7392_—involves the vanilla MobRenderer.
If the problem stems from there, it may need to be addressed by the other mod or in another part of the rendering pipeline.

If possible, could you record a short video capturing a few seconds before the crash, including any NPC equipment changes, and then the crash itself? This could help identify the exact trigger.

commented

I can't reproduce the crash now (so it stays fun)
Maybe I should contact the fantasy armor mod author instead, or even Geckolib then ?