Easy NPC

Easy NPC

2M Downloads

[Bug] Custom model resets to vanilla NPC when killed by it

Krampus69 opened this issue Β· 6 comments

commented

Minecraft and Mod version 🐞
Minecraft 1.20.1
easy_npc-forge-1.20.1-5.7.6

Describe the bug 🐞
Using a custom model on an NPC can reset it to its default skin when killed (by it ?)

To Reproduce βš™οΈ
Steps to reproduce the behavior:

  1. Setup an NPC with a custom model (Lifestealer from born in chaos for example)
  2. Make it agressive toward the player
  3. Die and respawn near him to see the skin get reset

Expected behavior βœ”οΈ
NPC keeps the custom skin it was assigned

Screenshots πŸ“Έ
I got it on video : https://streamable.com/iak7qa

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩
saturn |0.1.3
betterdungeons |1.20-Forge-4.0.4
stackablepotions |1.0.0
globalgamerules |8.0.0.11
sodiumextras |1.0.5
playeranimator |1.0.2-rc1+1.20
fabric_rendering_fluids_v1 |3.0.28+4ac5e37a77
fabric_models_v0 |0.4.2+7c3892a477
betternether |9.0.10
valhelsia_furniture |1.1.3
fabric_convention_tags_v1 |1.5.5+fa3d1c0177
modernfix |5.19.5+mc1.20.1
fabric_command_api_v1 |1.2.34+f71b366f77
legendary_additions |1.20.1-1.0.5
fabric_block_view_api_v2 |1.0.1+0767707077
fabric_command_api_v2 |2.2.13+561530ec77
yungsapi |1.20-Forge-4.0.6
kambrik |6.1.1+1.20.1
org_openjdk_nashorn_nashorn_co|15.4
harderspawners |46.25.3
clickadv |1.20.1-3.8
balm |7.3.9
fabric_screen_api_v1 |2.0.8+45a670a577
jeresources |1.4.0.247
betterfortresses |1.20-Forge-2.0.6
paraglider |20.1.3
cloth_config |11.1.136
autoleveling |1.19b
embeddium |0.3.31+mc1.20.1
structure_gel |2.16.2
advancementplaques |1.6.7
castle_in_the_sky |1.20.1
handcrafted |3.0.6
repurposed_structures |7.1.15+1.20.1-forge
fabric_game_rule_api_v1 |1.0.40+683d4da877
fantasy_armor |0.5-1.20.1
loot_journal |4.0.2
yungsbridges |1.20-Forge-4.0.3
resourcefulconfig |2.1.2
spark |1.10.53
quality_equipment |1.6
oculus |1.7.0
searchables |1.0.3
bettervillage |3.2.0
chunkpregen |1.20-4.4.4
fabric_entity_events_v1 |1.6.0+6274ab9d77
rootoffear |1.0.10
worldedit |7.2.15+6463-5ca4dff
itemphysic |1.8.2
fabric_rendering_data_attachme|0.3.37+a6081afc77
krypton |0.2.3
mobtimizations |1.20.1-1.0.0
fastleafdecay |32
disenchanting |2.2.3
cleanview |1.20.1-v1
bettermineshafts |1.20-Forge-4.0.4
essential |1.3.5.3
betterjungletemples |1.20-Forge-2.0.5
fabric_client_tags_api_v1 |1.1.2+5d6761b877
fabric_dimensions_v1 |2.1.54+8005d10d77
tslatentitystatus |1.5.1
quarkoddities |1.20.1
mowziesmobs |1.6.4
ati_structures |1.1.0
serene_shrubbery |1.2.0
mutantmonsters |8.0.7
fabric_model_loading_api_v1 |1.0.3+6274ab9d77
jei |15.20.0.105
nameless_trinkets |1.20.1-1.7.8
lithostitched |1.3.0
graveyard |3.1
attributefix |21.0.4
splash_milk |2.1.0
fabric_screen_handler_api_v1 |1.3.30+561530ec77
configlibtxf |4.2.5-forge
libraryferret |4.0.0
goblintraders |1.9.3
caelus |3.2.0+1.20.1
feathers |1.1
fabric_rendering_v1 |3.0.8+66e9a48f77
fabric_renderer_indigo |1.5.2+b5b2da4177
fastasyncworldsave |1.20.1-2.0
integrated_api |1.5.1+1.20.1-forge
glitchcore |0.0.1.1
crockpot |1.0.4
midnightlib |1.4.2
starlight |1.1.2+forge.1cda73c
jeitweaker |8.0.6
fusion |1.1.1
crafttweaker |14.0.44
fabric_particles_v1 |1.1.2+78e1ecb877
puzzlesaccessapi |8.0.7
forge |47.3.5
spawnbalanceutility |46.13.6
idas |1.10.0+1.20.1
dsurround |0.3.3
dungeons_arise |2.1.58-1.20.x
minecraft |1.20.1
smoothchunk |1.20.1-3.6
logprot |1.4
voicechat |1.20.1-2.5.25
sound_physics_remastered |1.20.1-1.4.5
terrablender |3.0.1.7
biomesoplenty |18.0.0.592
fabric_api_base |0.4.31+ef105b4977
mousetweaks |2.25.1
bettercombat |1.8.6+1.20.1
necronomicon |1.6.0
spectrelib |0.13.15+1.20.1
fabric_block_api_v1 |1.0.11+0e6cb7f777
fabric_resource_conditions_api|2.3.8+9ad825cd77
fastpaintings |1.20-1.2.7
kotlinforforge |4.11.0
flywheel |0.6.11-13
fabric_item_group_api_v1 |4.0.12+c9161c2d77
polymorph |0.49.5+1.20.1
zeta |1.0-24
entityculling |1.7.1
canary |0.3.3
fabric_registry_sync_v0 |2.3.3+1c0ea72177
immediatelyfast |1.3.2+1.20.4
fastfurnace |8.0.2
appleskin |2.5.1+mc1.20.1
fabric_recipe_api_v1 |1.0.21+514a076577
lootr |0.7.34.87
fabric_object_builder_api_v1 |11.1.3+2174fc8477
puzzleslib |8.1.24
fabric_sound_api_v1 |1.0.13+4f23bd8477
immersive_melodies |0.3.0+1.20.1
fabric_message_api_v1 |5.1.9+52cc178c77
cosmeticarmorreworked |1.20.1-v1a
chunksending |1.20.1-2.8
betterend |4.0.11
aquamirae |6.API15
responsiveshields |2.3
cristellib |1.1.5
carbonconfig |1.20-1.2.6
totw_modded |1.0.5
grapplemod |1.20.1-v13
treechop |0.19.0
skyvillages |1.0.4
easy_npc |5.7.6
notenoughcrashes |4.4.7+1.20.1
kuma_api |20.1.8
fabric_renderer_api_v1 |3.2.1+1d29b44577
animation_overhaul |1.3.1
globalpacks |1.16.2_forge
geckolib |4.4.9
fabric_item_api_v1 |2.1.28+4d0bbcfa77
com_github_llamalad7_mixinextr|0.2.2
betteroceanmonuments |1.20-Forge-3.0.4
connectivity |1.20.1-5.6
tipsmod |12.1.8
immersive_aircraft |1.1.3+1.20.1
gpumemleakfix |1.20.1-1.8
insanelib |1.15.0
bowinfinityfix |2.6.0
structureessentials |1.20.1-3.4
villagernames |8.1
controlling |12.0.2
prism |1.0.5
placebo |8.6.2
citadel |2.6.0
alexsmobs |1.22.9
iceandfire |2.1.13-1.20.1
tabstats |1.0.5
fabric_data_attachment_api_v1 |1.0.0+30ef839e77
mixinextras |0.2.0-beta.7
item_obliterator |2.3.0
bookshelf |20.2.13
relics |0.8.0.7
jeed |1.20-2.2.2
wunderlib |1.1.5
sodiumoptionsapi |1.0.5
melody |1.0.2
fabric_api |0.92.2+1.11.8+1.20.1
dummmmmmy |1.20-2.0.2
bclib |3.0.14
fabric_content_registries_v0 |4.0.11+a670df1e77
konkrete |1.8.0
farmersdelight |1.20.1-1.2.5
entity_model_features |2.2.6
entity_texture_features |6.2.5
ambientsounds |6.1.3
fabric_api_lookup_api_v1 |1.6.36+67f9824077
projectvibrantjourneys |1.20.1-6.0.4
endrem |5.3.3-R-1.20.1
valhelsia_structures |1.20.1-1.1.2
cmdcam |2.2.0
elenaidodge2 |1.1
born_in_chaos_v1 |1.5.2
lionfishapi |1.9
bountiful |6.0.3+1.20.1
modelfix |1.15
memorysettings |1.20.1-5.5
cataclysm |2.18
patchouli |1.20.1-84-FORGE
collective |7.84
cakechomps |6.2.0+1.20.1
cerbons_api |1.0.0
connectormod |1.0.0-beta.46+1.20.1
betterstrongholds |1.20-Forge-4.0.3
legendarysurvivaloverhaul |1.20.1-1.20.1-2.0.13
curios |5.11.0+1.20.1
sereneseasons |9.1.0.0
rereskillable |3.0.8-1.20.1
backpacked |2.2.5
resourcefullib |2.1.29
architectury |9.2.14
doapi |1.2.15
ftblibrary |2001.2.4
customvillagertrades |20.25.0
beachparty |1.1.5
ftbteams |2001.3.0
ftbquests |2001.4.9
fabric_loot_api_v2 |1.2.1+eb28f93e77
cupboard |1.20.1-2.7
mru |1.0.2+1.20.1+forge
fabric_networking_api_v1 |1.3.11+503a202477
framework |0.7.8
observable |4.4.1
servertabinfo |1.3.8
fabric_lifecycle_events_v1 |2.2.22+afab492177
effortlessbuilding |3.9
fabric_key_binding_api_v1 |1.0.37+561530ec77
wwoo_forge |2.0.0
fabric_transfer_api_v1 |3.3.5+631c9cd677
xpfromharvest |1.2.4
amendments |1.20-1.2.12
limitedchunks |1.8
rmh |1.0.1+MC1.20.x(Forge
octolib |0.4.2
spawncapcontrolutility |46.1.2
conjurer_illager |1.1.6
fabric_resource_loader_v0 |0.11.10+bcd08ed377
obscure_api |15
curiosquarkobp |1.2.5
invmove |0.8.4
create |0.5.1.h
waystones |14.1.6
fastsuite |5.0.1
clumps |12.0.0.4
fabric_mining_level_api_v1 |2.1.50+561530ec77
tumbleweed |0.5.5
artifacts |9.5.13
configured |2.2.3
decorative_blocks |4.1.3
dungeoncrawl |2.3.14
call_of_yucutan |1.0.13
betterdeserttemples |1.20-Forge-3.0.3
hopour |1.1.4
distanthorizons |2.1.2-a
walljump |1.20.1-1.2.7-forge
blueprint |7.1.0
upgrade_aquatic |6.0.1
fabric_transitive_access_widen|4.3.1+1880499877
simplyswords |1.56.0-1.20.1
enchdesc |17.1.19
moonlight |1.20-2.13.26
extragore |5.2.3.1
endermanoverhaul |1.0.4
regions_unexplored |0.5.6
fabric_blockrenderlayer_v1 |1.1.41+1d0da21e77
mixinsquared |0.1.1
creativecore |2.12.22
smoothboot |0.0.4
sounds |2.2.0+1.20.1+forge
iceberg |1.1.21
citresewn |1.20.1-5
spartanshields |3.1.1
quark |4.0-460
supplementaries |1.20-3.1.5
legendarytooltips |1.4.5
mobsunscreen |3.1.1
fastbench |8.0.4
irons_spellbooks |1.20.1-3.4.0.4
legendarycreatures |1.20.1-1.0.12
fabric_biome_api_v1 |13.0.13+dc36698e77
fancymenu |3.3.2
coroutil |1.20.1-1.3.7
creeperoverhaul |3.0.2
ferritecore |6.0.1
yet_another_config_lib_v3 |3.5.0+1.20.1-forge
rrls |4.0.6.1+mc1.20.1-for
betterf1 |1.0
expandability |9.0.4
valhelsia_core |1.1.2
overflowingbars |8.0.1
loadmyresources |1.0.4
healingcampfire |6.1
fabric_data_generation_api_v1 |12.3.4+369cb3a477
betterfoliage |5.0.2
fabric_events_interaction_v0 |0.6.2+0d0bd5a777
presencefootsteps |1.20.1-1.9.1-beta.1

Additional context πŸ“
Getting killed multiple times fixes the issue, at some point the custom skin comes back 🀷
Thank you for your mod ! And thank you for fixing the npc overlapping in dialogs issue, It is so cool to see how efficient you are πŸ™

commented

Thank you for the detailed report. I attempted to reproduce the issue and was able to replicate it, but only with larger mod packs like the latest "BMC4" pack. This also revealed some related issues, such as #385.

Based on your video and description, I have a good understanding of what’s happening. To ensure custom models work as intended, the mod spawns a "dummy" entity for the selected model and swaps it with the NPC model. This process occurs only on the client side, meaning the server has no knowledge of this "dummy" entity.

The issue arises because some client-side "optimization" mods are removing the "dummy" entity when it goes out of the player’s sight. The Easy NPC mod automatically attempts to restore the "dummy" entity after a delay to avoid performance issues caused by constant updates. This is why the entity reappears after a certain time rather than immediately.

I plan to implement an additional check that recreates the "dummy" entity when the player respawns. However, it’s possible that similar issues may occur when the NPC is far away in unloaded chunks and optimization mods decide to remove the "dummy" entity again.

commented

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

commented

Hi ! Just refreshing the page so it won't get stale

commented

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

commented

This issue was closed because it has been stalled for 5 days with no activity.

commented

Hi! Still there, maybe this ticket could be opened again since the issue is not fixed yet and it can be a big issue