Easy NPC

Easy NPC

2M Downloads

[Feature Request] Toggle feedback messages from commands

RuneOracle opened this issue · 4 comments

commented

I've created an addon for private use (public if testing goes well) that gives a "flag" system to npcs, to solve repeating dialogue/setup branching paths when talking to them again etc. However, the message in chat "Open dialog for X", is somewhat inconvenient for the sake of "immersion".

Ideally, i'd just like a way to toggle the feedback messages from commands. It's kinda just that simple haha.

Alternatively i was going to just block the message from being sent in chat, but that's only a worst-case scenario resort.

For more context, this is specifically the message i'd like to not display:
[23:31:29] [Render thread/INFO]: [CHAT] [Server: ► Open dialog for Humanoid['Test NPC'/1, l='ServerLevel[NPC Testing]', x=-40.50, y=46.00, z=-19.50] with class_3222['RuneOracle'/753, l='ServerLevel[NPC Testing]', x=-37.99, y=46.00, z=-20.69] and dialog dc5c7986-daef-30c1-a02a-b09b442ee34f]
The message is posted whenever I execute the command as myself, or whenever I have the npc execute my command that triggers the open dialog command. Can elaborate more if needed.

commented

servermessage

Easy_NPC_Branching_Dialogue_Test_low.mp4

I've created a private build of Easy NPC that modifies the DialogCommand.java and removes the green text shown in the screenshot, although I'd love if this were a toggleable feature of some form that way I can just use the mod as it updates over time without needing to make the change myself! I've also attached a small clip showcasing the addon I'm working on, to give better understanding of why I want said feature. The clip is using the private build to suppress the green feedback messages. Going to mark this as closed, as it's not an issue anymore, but please do consider this request.

commented

Thanks for the report!

The message you’re seeing is actually the feedback from the command itself.
However, I could add a flag to suppress it or move it to the debug logger instead to reduce chat spam.

Keep in mind, there is also a gamerule (sendCommandFeedback) that controls whether command outputs are echoed in chat.
This is handled by the game itself and not something I can influence directly.

Let me know if you have any preferences on how you'd like this to be handled!

commented

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

commented

This issue was closed because it has been stalled for 5 days with no activity.