Easy NPC

Easy NPC

2M Downloads

[Bug] Can't remove Open Default Dialog/Open Trading commands

Krampus69 opened this issue ยท 7 comments

commented

Minecraft and Mod version ๐Ÿž
The used Minecraft and Mod version.
Minecraft 1.20.1
Forge 47.3.22
easy_npc-forge-1.20.1-5.9.0

Describe the bug ๐Ÿž
Removing the Open Default Dialog/Open Trading commands from a NPC doesn't save in a NBT structure. They will appear again once the NPC generates in the structure in the game.

To Reproduce โš™๏ธ
Steps to reproduce the behavior:

  1. Add a NPC to a structure (for example a village house)
  2. Remove the Open Default Dialog/Open Trading commands from the ON_INTERRACTION menu
  3. Save the NBT with the NPC
  4. Create a world and find the structure with the NPC
  5. Witness the parameters being there still

Expected behavior โœ”๏ธ
Options saved in ON_INTERRACTION menu shouldn't change

Screenshots ๐Ÿ“ธ

The NPC setup in the NBT structure
Image

The same NPC once generated in the world
Image

Is the issue happening in combination with other mods? (If yes, please provide a full list) ๐Ÿงฉ

modlist.txt

Additional context ๐Ÿ“
The reason why this issue is important is that my NPC changes its dialog depending on some criterias (player has a specific item in its inventory, player has achieved a quest related to this NPC, etc...)
With this bug, the entire questline I made for this NPC is not working. I was planning on releasing this new quest tonight for the modpack but this problem stopped me after working on it the whole week
If you can check out this issue on your side and tell me if you manage to reproduce it, that would be very helpful

Thank you again

commented

bump!

commented

Hey, this issue is still going and there were no answers since 3 weeks. Are you still active on this mod ? I'd rather know because if my entire modpack revolves on your mod but you don't work on it anymore, it would help to know so I can organize myself and rework my content now.

commented

Hey, this issue is still going and there were no answers since 3 weeks. Are you still active on this mod ? I'd rather know because if my entire modpack revolves on your mod but you don't work on it anymore, it would help to know so I can organize myself and rework my content now.

Thanks for reaching out! Yes, Iโ€™m still actively working on the mod.
If I had discontinued it, the GitHub page would either be archived or clearly marked as no longer maintained.

However, I was on sick leave for about two weeks due to influenza, which was also reflected in my GitHub status.
Iโ€™m still in recovery, but Iโ€™ll be working through the backlog over the coming days and weeks.

I appreciate your patience!

commented

Good to know, hope you're feeling better Markus ๐Ÿ‘

commented

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

commented

This issue was closed because it has been stalled for 5 days with no activity.

commented

Ho no the ticket has been closed, i'm still waiting for this fix to release my questbook