Easy NPC

Easy NPC

2M Downloads

[Feature Request] Survival mode specific features like (change owner, attack players but not owner, ...)

norfaremc opened this issue · 4 comments

commented

Would love it if you could make it so NPCs are accessible in survival mode, but only certain features are accessible in survival mode. For my server, I need to be able to let players have their own NPCs that they can have follow them, and I want players to be able to customize them as well without having to be in creative mode. Additionally, having a way for us to set the owner of the NPC, so only OP'd players and the NPC owner can access it's menu. Also having a "Attack Players except..." button so we can prevent the NPC from attacking it's owner, would be really awesome!! I can tie these NPCs in with a quest mod for 1.19.2, and with these changes, the Quest NPCs can make the game so much more interactive. Thanks for all you do, this mod is amazing!!

commented

Thanks for the detailed feedback.

Technically most of the NPCs options should be already available in survival mode with some restrictions.
The user need to use the NPC wand to edit an NPC in survival mode.
You can additional disable specific options over the config files or setting the needed permission level for some options.

At the moment I see the following missing features:

  • Option to change the owner of the NPC
  • Option to attack players, but not the owner.

Let me know if something specific is not working in survival mode and happy to take a closer look. Thanks.

commented
  • Make it so players can only edit with the wand the NPCs they own (unless OP'd)
  • Additionally, with your collaboration with Armourer's Workshop (THANK YOU BTW!!!), having a way for players to only be able to use the NPC skin wand on the NPC they own, so they can't mess with other player's NPCs would be great. I don't know if that's something you can do or if I need to reach out to AW for that.
  • Would love players to be able to change the dialogue in survival without being able to edit actions (they can cheat that way, in the advanced Dialogue section)
  • Make it so players in survival can edit Objectives (so they can control how the NPC is following, what theyre attacking, etc)
  • Have a mob/player blacklist we can edit so we can prevent an NPC from attacking certain players and mobs)
  • If an NPC is following you, it should follow even when you teleport away
  • Whistle for the NPC, to bring it back to it's owner
  • Attackable by players and attackable by mobs feature :)

As of right now, in Forge 1.19.2, using the edit wand on an NPC in survival will kick/disconnect players from the server. Here is the debug log:

debug.log

commented

Thanks for the details, the debug.log you shared seems to be from a client or was this a LAN Server ?

I don't found anything in the log which shows that players get disconnected by using the wand on an NPC.
So it would be nice if you could share the debug.log or crash.log from the affected player so see what's happen.

The actions are bound to the owners permission level, so a normal user should not be able to really use /give or /say commands.
They could enter them in the UI, but they should have no effect at all.

Objectives on the other hand will increase the server load if you allow them for normal players.
If they are enabling all options and creating some NPCs they could lower the server performance by a lot.

But thanks again for the feedback. There are some new good ideas and some others are already covered in other feature requests.

commented

The actions being bound to the player’s permission level is perfect, thank you!

If you would be up to it, having a config that enables objectives to survival players would really help, or at the very least just the “follow” tab, as that’s really all I care about. I would love to give players (there’s really only a handful of players who will have their own NPC) the ability to have their NPC not follow them anymore, so the NPC isn’t getting in the way so much. I’m not worried about server performance as I’m running on a high end dedicated machine, but I do appreciate the warning about performance dropping.

On another note, those crashes were strange and only happened twice. Upon restarting my computer, it stopped crashing, so it likely was more on my computer’s end than anything, go ahead and disregard the debug :)