Easy Villagers

Easy Villagers

28M Downloads

Farmer block does not support non-vanilla

shanoaice opened this issue ยท 4 comments

commented

Bug description

Right-clicking the Farmer block with non-vanilla crops will open the GUI instead of planting them in the block.

Steps to reproduce the issue

  1. Pick a seed from other mods, such as Flax Seed from Thermal Cultivation.
  2. Right click the Farmer block.
  3. The output GUI of Farmer block opens.

Expected behavior

The crop (seed) should be planed in the Farmer block.

Versions

  • Minecraft version 1.18.2
  • Forge version 40.1.74
  • Mod version 1.18.2-1.0.11

Other mods

  • Pam's HarvestCraft 2
  • Thermal Cultivation

Extra Information

I am not sure whether detection of a valid seed in FarmerTileentity is proper. It seems like that in Thermal Cultivation Plant.CROP is properly set, but my searching technique is not good enough to determine whether the corresponding seed item is an instance of IPlantable. (but I think it should be. I have no idea why this doesn't work.)

commented

The block will only accept seeds that villagers can plant and farm.

Yes, but according to this code everything that is an instance of IPlantable and has a type of PlantType.CROP should be harvestable by a villager.

commented

Then I am puzzled why I can't plant seeds added by Thermal Cultivation into the Farmer block. I will try look into their code further. Thanks!

commented

The block will only accept seeds that villagers can plant and farm.