Easy Villagers

Easy Villagers

13M Downloads

Restock problem with multiple villager professions sharing the same workstation

lordlethis opened this issue ยท 3 comments

commented

Please read the FAQ before submitting a bug report!
That URL leads to a 404 :/

Bug description
If multiple villager professions share the same workstation, then only one of those professions seems to be able to restock inside trader blocks.

More concrete: EvilCraft adds a werewolf villager profession, which uses the smoker as its workstation (same as the vanilla butcher). Putting an unemployed villager and a smoker into a trader block always sets it's profession to werewolf (not really an issue and easy to get around). However, if you lock the villager to butcher before putting it in, it won't restock.

Steps to reproduce the issue

  1. Run a game with both EvilCraft and EasyVillagers (e.g. All the Mods 8)
  2. Put a butcher and a smoker into a trader block. Add a smoker.
  3. Exhaust a trade, wait for restock. ... ahem
  4. Restock's not happening

Expected behavior
I'd expect the butcher to restock, just like it does outside the trader block. :-)

Versions

  • Minecraft version: 1.19.2
  • Forge version: 43.2.14
  • Mod version: easy_villagers-1.19.2-1.0.11

Other mods
All the Mods 8 (1.0.22), notably EvilCraft.

Unrelated Remarks
Thank you for making this mod. I love it and I don't want to play without it anymore <3

commented

Having multiple professions with the same workstation is not really intended to be done. I would report that to EvilCraft.
If there are multiple professions to choose from there is no real strategy which one to pick, which is a problem with this mod.

commented

They have CyclopsMC/EvilCraft#843 from a while ago, but seeing as there's no issue outside the trader block, I don't see them changing anything on their end. :-)

That said, my only issue with the current behaviour is that it's not restocking butchers that were locked into their profession by trading outside the trader block.

Which profession an unemployed villagers is assigned seems largely irrelevant to me (from a user's perspective; peeking into the code, that seems largely the same thing, since it compares the villager's profession to "the" profession associated with the workstation in the trader block, rather than comparing the workstation with the workstation associated with the villager's profession).

Either way, feel free to close the issue if you feel it's not something you want to accommodate; I certainly won't hassle you over it. <3

commented

That said, my only issue with the current behaviour is that it's not restocking butchers that were locked into their profession by trading outside the trader block.

Villagers only restock if they have a valid workstation block.