Please read the FAQ before submitting a bug report!
Check!

Bug description
Trader and Auto Trader do not appear to restock. At a minimum, they do not respect changing the min_restock_time and max_restock_time variables in the server config file.

Steps to reproduce the issue
No errors thrown in logs. Must be recreated in game to see.

1. Start fresh world using a server config for Easy Villagers that has these changes:

[trader]
	#The minimum amount of time in ticks the trader takes to restock
	#Range: > 1
	min_restock_time = 49
	#The maximum amount of time in ticks the trader takes to restock
	#Range: > 2
	max_restock_time = 51

[auto_trader]
	#The minimum amount of time in ticks the auto trader takes to restock
	#Range: > 1
	min_restock_time = 49
	#The maximum amount of time in ticks the auto trader takes to restock
	#Range: > 2
	max_restock_time = 51
	#The cooldown in ticks for the auto trader to do a trade
	#Range: > 1
	trade_cooldown = 50

2. Grab a random villager with trades and place it in a Trader or Auto Trader
3. Use all trades for any number of trades. Note that the trade_cooldown of 50 ticks works as intended.
4. Wait as nothing else happens.

Expected behavior
Restock should occur in 49-51 ticks as in the server config.

Log files
Initial Test in Creative mode
latest.log
Second Test (same world) in Survival mode - I thought maybe duping was the cause, but that didn't change anything
latest.log

Versions

• Minecraft version - 1.16.4
• Forge version - forge-35.1.37 (up to date)
• Mod version - 1.16.4-1.1.28 (up to date)

Other mods
Tested with literally just Easy Villagers mod and forge on a fresh world. Problem persists.

I tested it and it works perfectly fine. Please make sure, you close the GUI if the trades are locked. This is a vanilla Minecraft limitation, unfortunately.

Can confirm , auto traders don't restock ever. Manual traders restock for me though

Tested it again for auto traders and it works as intended.

I played around with this for a while and I FINALLY figured out what the problem was: It turns out that you have to have the villager's station in there with him for it to work. I went back and looked through the mod page again just to see if I missed something there.

As it turns out I missed that in the gifs of the Trader and Auto Trader you quickly placed the station with the villager. But there is nothing said about that being required. I highly recommend adding that as a notice for ease of use.

I'm glad it works! It will make my modpack a lot easier to finish. lol I can pm you or something if you are curious to look at it. :)

Consider this topic closed - not a big, just an unnoticed feature.

Edit: This works fresh world and in my modpack that changes the recipes around a bit. Thank you for your quick reply and patience as we figured this out.

Edit 2: Note also that this seems to work even with the GUI open (at least in the Auto Trader).

As it turns out I missed that in the gifs of the Trader and Auto Trader you quickly placed the station with the villager. But there is nothing said about that being required. I highly recommend adding that as a notice for ease of use.

If you watch the GIFs and a little knowledge about vanilla minecraft it should be self explanatory.

Edit 2: Note also that this seems to work even with the GUI open (at least in the Auto Trader).

Yes, this just applies to the vanilla trading GUI.