Easy Villagers

Easy Villagers

28M Downloads

[1.16.5] Zombie villagers used for converting villagers cause minor negative gossip

JohnGohan opened this issue · 14 comments

commented

Bug description
Villagers converted and cured using a generated zombie villager get minor negative gossip.

Steps to reproduce the issue

  1. Locate an igloo. (+basement)
  2. Convert the already present villager using the available zombie villager and cure it.
    2.1 (optional) Also cure the zombie villager while you are it to have a comparison.
  3. The converted villager will have 175 negative gossip (check via /data get entity). Also its trades cannot be rerolled like intended.

Expected behavior
Regular vanilla mechanics as to where any form of converting/curing villagers results in discounts.

Log files
debug.log https://pastebin.com/4US82rsZ
latest.log https://pastebin.com/bxHuRhPX

Versions

  • Minecraft version: Minecraft* 1.16.5
  • Forge version: 36.1.0
  • Mod version: easy_villagers-1.16.1-1.0.10

Other mods
image

Screenshots
Converted/cured villager
javaw_q7WVn4OcVt

Cured zombie villager (already was generated as one)
javaw_FIVykGRU6u

Forge 36.1.0 + easy_villagers-1.16.1-1.0.10 ONLY
javaw_imSM1BaGtU

commented

Edited my post so everything is in one place

commented

Replicated your steps exactly and it works perfectly fine.

In the trader:
image

In the world:
image

Cycling trades also works fine.

Please try if it happens without any other mods installed.

commented

Like I've said.
Using the latest easy villagers alpha + forge version 36.1.0 lead to the same results as explained
a fresh 1.16.5 install with forge and the mod itself

commented

I've tried exactly the same and it works perfectly fine.

Do the prices increase even if you never pick the villagers up?

commented

Considering the fact that already whilst in the process of curing the zombie villagers (outside of the one who generated as such) they had negative gossip I did not test it without picking them up.
However there should be zero difference due the data values on each one of them.
The last screenshot in particular shows that.

commented

If there is no difference, then it is not an issue by this mod. It doesn't change anything in the vanilla villager.

commented

Well in "no difference" I was talking about the behavior between a pickup or not.

I will try downgrading to the latest beta aka ver. 1.0.4 and check if it persists

commented

After quickly following the same steps using the easy_villagers-1.16.5-1.0.4.jar I can clearly say that it does not appear to be a thing in the beta.

A random savanna villager I used for testing
javaw_upJwjmNHTT

debug.log https://pastebin.com/Jh82X1R2

(I would assume the latest.log is not needed as all the information is included?)

commented

Please add your game logs.

commented

I tested it again in a non-dev environment and it also works fine.

image

Can you please try a fresh installation with just the mod?

commented

I have been using a fresh installation for the past hour. Either way I have just like in your screenshot done it without picking up the villager afterwards > no issues.
Taking it and putting the villager in a trader changed that.
Currently in the process of downgrading from alpha to alpha and even 1.0.7 still gives me increased prices rather than discounts upon picking it up and throwing it in a trader.

commented

I was finally able to reproduce the issue. I will look into it.

commented

So, the minor negative thing is because the villager was chased by a zombie. Normally it doesn't affect your trades, but the easy villagers mod adds an option called "universal reputation". This sums up every gossip entry that the villager has. This is, so every player sees the same prices in the trader. If you don't want that, you can just turn it off in the config.

commented

Good to know. I will look into the serverconfig file and adjust things to my preferrence.
Hopefully I didn't cause you too much trouble figuring out what may be the cause of all.

It would be amazing to have a small section on the curseforge page dedicated to configurable content instead of simply linking an FAQ of some sort. Or possibly include this particular case as some players faced the same/similar problem.

Have a great day and keep on doing your thing because Easy Villagers is definitely one of the few highly recommendable 1.16.x modifications out there available.