Needs an extra check to fully respect FTBChunks claims
xenoflot opened this issue ยท 6 comments
Please read the FAQ before submitting a bug report!
Bug description
FTBChunks prevents the placement of villagers (as expected) but non-trusted players can still pick up Easy Villagers with a shift-rightclick (not desired)
Steps to reproduce the issue
n/a
Expected behavior
Players not trusted by FTBChunks (IE not in the player's party) should not be able to pick up villagers.
Log files
n/a
Versions
- Minecraft version 1.16.5
- Forge version 31.1.66 (I think)
- Mod version easy_villagers-1.16.5-1.0.11
Other mods
- ftb-chunks-forge-1605.3.1-build.36
Screenshots (Optional)
Screenshots of the issue.
@henkelmax Can you offer a bit of explanation why the mod does not support ftbchunks? What technical hurdles they are preventing this? Would you accept pull requests regarding this?
@henkelmax Can you offer a bit of explanation why the mod does not support ftbchunks? What technical hurdles they are preventing this? Would you accept pull requests regarding this?
I never looked into their code, but land claiming in modded Minecraft never works 100%, since the mods cannot know whether an area is protected or not.
It's not practical for you to check for all possible claim systems but since FTBChunks is probably the No.1 permissions system for modded MC and is included in pretty much every major pack, integrating with it would probably give an 80% ROI.
I want to avoid dependencies on other mods, since that heavily slows down updating the mod to newer versions.
It also makes no sense to not be able to pick up your own corpse in a claimed area. If you are worrying about others picking up your stuff, you can disable that in the config.
It's not practical for you to check for all possible claim systems but since FTBChunks is probably the No.1 permissions system for modded MC and is included in pretty much every major pack, integrating with it would probably give an 80% ROI.