Eating Animation [Fabric]

Eating Animation [Fabric]

7M Downloads

EatingAnimation mod breaks potion CIT (Optifine)

TheSweatyYeti opened this issue Β· 19 comments

commented

If you have a resource pack that adds CIT (Custom Item Textures) to potions using Optifine, the potions in the GUI will not use the CIT provided by the resource pack. The potions held in the players hands, on the ground, and in item frames will use the CIT, but in the inventory, they will not.

The mod doesn't effect all CIT. As shown in the clips, CIT for axolotl buckets are unaffected.

I'm unsure why the mod breaks potion CIT considering the mod doesn't give potions a drinking animation.

Videos:
Without EatingAnimations mod.
With EatingAnimations mod.

commented

Can confirm, I have the same issue, but with Fabric CIT Resewn mod.

Interesting. So it definitely isn't an Optifine issue. It must definitely be an issue with this mod. Good to know.

commented

This site does not open, maybe due to the fact that I am in another country ))

Try this then.
It's definitely something with your mod.

Without EatingAnimations mod.
With EatingAnimations mod.

commented

If you have a resource pack that adds CIT (Custom Item Textures) to potions using Optifine, the potions in the GUI will not use the CIT provided by the resource pack. The potions held in the players hands, on the ground, and in item frames will use the CIT, but in the inventory, they will not.

The mod doesn't effect all CIT. As shown in the clips, CIT for axolotl buckets are unaffected.

I'm unsure why the mod breaks potion CIT considering the mod doesn't give potions a drinking animation.

Videos: Without EatingAnimations mod. With EatingAnimations mod.

Can you send a video not through this site?

commented

Can you send a video not through this site?

Why? What's wrong with this site? What site do you want me to use if you don't want that website in particular?

commented

Can you send a video not through this site?

Why? What's wrong with this site? What site do you want me to use if you don't want that website in particular?

This site does not open, maybe due to the fact that I am in another country ))

commented

I too am having this issue. Installing the Eating Animation mod makes Potion and Enchanted Book resource pack textures get overridden back to their defaults.

Here’s some examples of CIT packs that break with Eating Animation installed alongside CIT Resewn:
https://www.curseforge.com/minecraft/texture-packs/xalis-enchanted-books
https://www.curseforge.com/minecraft/texture-packs/xalis-potions

commented

I had some report too of people having some issue with xali's potions and your mod which is a bummer. I looked into your assets to add compatibility but nothing seems to touch the potions so I'm not entirely certain why the issue is. There is around 3 or 4 people on my discord that came to me with that issue.
But this seems to be applied to every CIT texture in the GUI. Nowhere else.

commented

I had some report too of people having some issue with xali's potions and your mod which is a bummer. I looked into your assets to add compatibility but nothing seems to touch the potions so I'm not entirely certain why the issue is. There is around 3 or 4 people on my discord that came to me with that issue. But this seems to be applied to every CIT texture in the GUI. Nowhere else.

It turns out the problem is somewhere in CIT ?

commented

You should be able to fix it if you shadow getHeldItemModel instead of accessing the model manager yourself in the fallback at:

return bakedModel4 == null ? this.models.getModelManager().getMissingModel() : bakedModel4;

I made CIT Resewn modify the output of getHeldItemModel, it should also by definition make the fallback go through vanilla code points which is probably going to fix the optifine behavior as well.

#2 Might be related.

commented

Apologies, it was meant for the dev.

lol fair enough. Better they get it and understand it than me

commented

lol I'll pretend I understood any of what you just said and take your word for it

commented

lol I'll pretend I understood any of what you just said and take your word for it

Apologies, it was meant for the dev.

commented

Having the same problem with: https://www.curseforge.com/minecraft/texture-packs/visual-enchantments
The items on the player inventory do not show the CIT

commented

I have the issue too, I am using Xali's Potions and EatingAnimation and it just shows the vanilla textures.

commented

Can confirm, I have the same issue, but with Fabric CIT Resewn mod.

commented

@Theoness1 @SHsuperCM
I found this error in my logs:
[main/WARN]: Warnings were found!

  • Mod 'CIT Resewn: Defaults' (citresewn-defaults) 1.0.1+1.18.2 conflicts with any version of mod 'Eating Animation' (eatinganimationid), which is present with the following versions: 1.6!
    • While this won't prevent you from starting the game, the developer(s) of mod 'CIT Resewn: Defaults' (citresewn-defaults) have found that this combination may cause issues. You should remove one of the mods or check for updates that resolve the issue.

@Theoness1 can you fix this since SHsuperCM (dev of CIT Resewn) suggested a workaround several comments above
Also there is a pull request for this issue as well
thanks in advance <3

commented

For people who still want this, here is JulienRaptor01's fork which solves the issue. A binary can be downloaded here.

@Julienraptor01 can you make a new PR? I would but there are apparently some other changes you made in your fork which maybe are not needed.

Why do you link your redistribution of my build instead of just linking my release ?

Why should i make a new PR ? This PR is fine currently. (it's not perfect and Theoness1 is looking at a better fix)

My fork don't change this fix. My fork is an addition of this CIT fix + my compatibility pack for VTSU integrated in the mod.

commented

For people who still want this, here is JulienRaptor01's fork which solves the issue. A binary can be downloaded here.

@Julienraptor01 can you make a new PR? I would but there are apparently some other changes you made in your fork which maybe are not needed.

commented

fixed soon