Ecliptic Seasons

Ecliptic Seasons

17.4k Downloads

[Bug][1.20.1] Snowy Edges breaks even when TopFaceCulling is enabled

Closed this issue · 11 comments

commented

description:
snow overlays do not work properly and create these transparent holes you can see caves through

to reproduce:

  1. install continuity
  2. enable 'snowy edges' in the config
  3. set the term to winter solstice
  4. set weather to rain
  5. let snow pile up

screenshots:

Image Image

versions:

  • ecliptic seasons 0.12.0-pre12
  • ecliptic seasons: multimod patch 0.15.2
  • minecraft 1.20.1
  • forge 47.4.0
commented

This is not a bug, but a potential expected conflict. Snowy Edges is just an optional feature.
Additionally, you did not report whether you were using a connector.

Continuity does not have a Forge version for 1.20, so we do not prioritize compatibility testing on that version. Debugging is particularly difficult due to code obfuscation in Forge 1.20.

We do have Continuity 1.21.1 NeoForge version available, but no Forge version for 1.20.1.

commented

Based on my understanding of Continuity's code, this mod is actually quite aggressive. It attempts to wrap all registered models into its own types.

The problem is that the Fabric Renderer API also hijacks all Fabric models when enabled — which, unfortunately, is exactly what Continuity does.

As a result, this creates a lot of complications and makes certain things difficult to handle.

commented

This issue should not be closed.

commented

We need more investigation information.

commented
Image
commented
Image
commented

Strange, this works perfectly fine for me. I don’t understand why it’s causing problems on your side. I suspect there may be issues with other mods as well.

commented

alright, first off, i apologize for closing the issue randomly, thought this compatibility wasn't really planned when you said 'we do not prioritize compatibility testing on that version.'

second, i just re-tested everything on a clean version with just ecliptic seasons (pre12, tried other versions prior to pre14-1 too), continuity, connector, and a resource pack called 'overlay's' and it seems to be working now, i suppose i had a weird resource pack or mod conflict which screwed with the overlays a lot.

if i find the mod that causes this rendering bug to happen, ill let you know.

sorry if i caused any inconvenience.

Image
commented

wait, this isn't actually a problem with continuity! apparently it's the TopFaceCulling setting that breaks the snowy edges rendering.

this is with TopFaceCulling set to true:

Image Image

and this is with TopFaceCulling set to false:

Image Image

thankfully this wasn't a mod or resourcepack conflict. i assume this is a bug. i don't actually understand what this setting does, i thought it's supposed to cull the top face of the overlay that appears on leaves so that you can see the sky through the bottom?

commented

This is actually quite an old option. It removes the top faces of all snow-covered block models to avoid Z-depth conflicts, while also providing some optimization (since one face is reduced). However, this process is rather time-consuming, so in practice it’s better not to perform it. That’s why I provided this option in a certain version to disable it.

commented

In that case, the issue can be resolved — simply don’t cull the faces at this point.