EditSign (Forge&Fabric)

EditSign (Forge&Fabric)

820k Downloads

Support mods

Romz24 opened this issue ยท 2 comments

commented

Can you add support for third party mods? There are many mods that add plaques, but they cannot be edited.

commented

I don't reeally know what part of the mod adds "plaques" though seems like it adds a BetterNetherSign.

Not sure I can directly add support for it as it is does not provide an API for it (If I'd add support for it, my mod would depend on BN and everyone would need to have it).

The easiest would be to have the mod inherit the behavior of SignBlockEntity.

For example here https://github.com/paulevsGitch/BetterNether/blob/f996cccbb5985d19b57063b386ede1a1d146474e/src/main/java/paulevs/betternether/blockentities/BNSignBlockEntity.java#L32 it defines a behaviour from BlockEntity, so I have no way to know on my side that this is supposed to be a sign.
If instead this class inherits from the BlockSignEntity, all the behaviour wouldn't have to be redefined and EditSign can hook into it like if it was a normal sign (https://github.com/RakSrinaNa/EditSign/blob/9b7e7ca6dd2207e8286a179176da9672d633ed62/src/main/java/fr/raksrinana/editsign/mixin/SignBlockEntityMixin.java#L16-L23).

commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.