Equivalent Exchange 3

Equivalent Exchange 3

Mods
2M Downloads

Mod compatibility crash with version 512

wasweb opened this issue ยท 15 comments

commented

I have a pack with a lot of mods so went ahead and tried the latest version of EE3. Unfortunately, it crashed after loading the world.
Mod version: 0.3.0.512
Crash log: https://www.dropbox.com/s/c3r4jaqbxd9zt76/crash-2016-05-19_16.14.02-server.txt

commented

The issue is here:

Equivalent-Exchange-3/src/main/java/com/pahimar/ee3/recipe/RecipeRegistry.java

Lines 71 to 79 in 35841c2

public Multimap<WrappedStack, List<WrappedStack>> getRecipeMappings() {
if (immutableRecipeMap == null) {
immutableRecipeMap = ImmutableMultimap.copyOf(recipeRegistry.recipeMap);
}
return immutableRecipeMap;
}

The fix will be to add detection for multiple entries, rather than a blanket "add all"

commented

Yes, fixed. Thank you for your work!

commented

Hello, I'm still getting this crash with the new version (0.3.0.513)

report: http://pastebin.com/yC2cCbXz

commented

Hi, I am also still getting this crash server side with version 0.3.0.513.
http://pastebin.com/wBMUzrHm

commented

i dont have the same crash anymore at least when i try to open my existing world i have this crash http://paste.ee/p/ePgOF
with the 0.3.0.513 version
if i start a new world i get the old crash

commented

Same issue here, just with sangunite from Metallurgy

commented

@SkinHeadBaby I just tested with the same two versions of PneumaticCraft and BuildCraft and I was unable to reproduce with the same code in 0.3.0.513

commented

@border999 this is not for other mods problems - please stick to posting logs for EE3 issues. It's also not for personal conversations.

commented

@border999 I deleted your comment because it has no bearing whatsoever on this issue

This is where it's crashing for some people - https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/recipe/RecipeRegistry.java#L88

Specifically, this has nothing to do with other mods "input." This has to do with a key constraint on the ImmutableMultimap which according to Guava's documentation should be fine. That's what I'm attempting to troubleshoot and debug. Using the same mods and versions as other people here I am unable to reproduce the error so currently I'm proofing the system even further in an attempt to resolve this.

commented

When trying to gen a brand new world on a server with 0.3.0.513 I got this error:
http://pastebin.com/wZYXNnMR
Then I created a new world on 0.3.0.507 then once the world was created I changed over the version to .513 and then got this error:
http://pastebin.com/0wW5se9x
I don't appear to be getting these errors client side but will now go and check.

commented

@border999 that's the same crash as you posted earlier, which was pointed out to not be an EE3 crash. It's Immersive Engineering. Go report it there. If you continue to abuse the issues section like this I will be forced to block you from this repo.

@kasper-tfg thank you for that - I'll investigate both

commented

Just posted 0.3.0.514 with some more changes - could you all give it a try and let me know how it works for you?

commented

Just tested 0.3.0.514 All appears OK at this time both client and server loaded up fine with already created worlds and new worlds. Thanks your a legend.

commented

0.3.0.514 works fine for me. Thanks for the fix.

commented

New build should be up shortly with a possible fix (0.3.0.513) - would you be able to test it with this same modset again and let me know if the issue is resolved?