Shift click issues with Transmutation Tablet in build 519
cylek56 opened this issue ยท 16 comments
Hello Pahimar,
Just want to report bugs:
(Win 10/ MC 1.7.10/ Java 1.8.091/ Forge 10.13.4.1614)
1-Glyph twinkles on each size (1x1, 3x3, 5x5)
2-Aeternalis blocks turn to Alchemical blocks when shift clicking the transmutation table
Same for pufferfish which turns to raw fish
Hope to help you a little
Respectfully
Came from twitter - I know I'm looking at the wrong part of this issue, but you might consider using a sine wave here instead of...uh...this? https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/client/util/RenderUtils.java#L85
Math.sin(world.getTotalWorldTime() / 100f)
Will be guaranteed smooth and based on world time so it stops when the game pauses
Yeah the render stuff was always fugly and wasn't going to be ported to 1.9 :) Good recommendation though!
Ah...small mistake...obviously sin returns negative values, you'd need to interpolate on 0..1 ( (sin(...) + 1) / 2f
)
Looked into TSIS, your bug is simpler than you may think.
ItemStack#clone()
exists for a reason ;)
https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/inventory/ContainerTransmutationTablet.java#L376
Shouldn't this also have the Item damage as well or I am miss reading something?
I caught that one. Thing is when you clone it you get weird other behaviour (a item dupe exploit in fact).
Pushed the piece that fixes the meta (4fac58d) however the dupe exploit still exists. That's the thing I'm more concerned about.
@MaPePeR a good catch, but the dupe exploit still exists even with that change
@pahimar what is the dupe exploit then? Can you elaborate?
Steps to reproduce;
- Teach yourself an Aeternalis Fuel Block
- In a new Transmutation Tablet, add a full stack of Aeternalis Fuel Blocks to the input section
- Shift click out a full stack of Aeternalis Fuel Blocks from the output section
- Re: twinkles - commit 43a384a should fix that issue for you
- This is not a shift click issue, but rather an issue with how the transmutation tablet consumes items for EMC in order to do the transmutation (see bug #1057)
With that said, going to close this issue and track the issue with the trans tablet in #1057