Equivalent Exchange 3

Equivalent Exchange 3

2M Downloads

Shift click issues with Transmutation Tablet in build 519

cylek56 opened this issue ยท 16 comments

commented

Hello Pahimar,

Just want to report bugs:
(Win 10/ MC 1.7.10/ Java 1.8.091/ Forge 10.13.4.1614)

1-Glyph twinkles on each size (1x1, 3x3, 5x5)
2-Aeternalis blocks turn to Alchemical blocks when shift clicking the transmutation table
Same for pufferfish which turns to raw fish

Hope to help you a little
Respectfully

commented
  1. Twinkles?
  2. Definitely a bug with shift click, investigating
commented

That's very odd - it should be a smooth glow effect. Hrm

commented

glyph

Easier to show what's going wrong

commented

Came from twitter - I know I'm looking at the wrong part of this issue, but you might consider using a sine wave here instead of...uh...this? https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/client/util/RenderUtils.java#L85

Math.sin(world.getTotalWorldTime() / 100f)

Will be guaranteed smooth and based on world time so it stops when the game pauses

commented

Yeah the render stuff was always fugly and wasn't going to be ported to 1.9 :) Good recommendation though!

commented

Ah...small mistake...obviously sin returns negative values, you'd need to interpolate on 0..1 ( (sin(...) + 1) / 2f )

commented

Looked into TSIS, your bug is simpler than you may think.

https://github.com/pahimar/Equivalent-Exchange-3/blob/master/src/main/java/com/pahimar/ee3/inventory/ContainerTransmutationTablet.java#L345

ItemStack#clone() exists for a reason ;)

commented
commented

I caught that one. Thing is when you clone it you get weird other behaviour (a item dupe exploit in fact).

commented

Clone/pass in the meta. The dupe exploit is there.

commented

Pushed the piece that fixes the meta (4fac58d) however the dupe exploit still exists. That's the thing I'm more concerned about.

commented

@pahimar this line drops the damage value information from itemStack.

Edit: Oh, Texasjake95 already pointed that out. I'm prettty sure thats the problem, though. Also: why does this method always return false? What is the return value supposed to indicate?

commented

@MaPePeR a good catch, but the dupe exploit still exists even with that change

commented

@pahimar what is the dupe exploit then? Can you elaborate?

commented

Steps to reproduce;

  1. Teach yourself an Aeternalis Fuel Block
  2. In a new Transmutation Tablet, add a full stack of Aeternalis Fuel Blocks to the input section
  3. Shift click out a full stack of Aeternalis Fuel Blocks from the output section
commented
  1. Re: twinkles - commit 43a384a should fix that issue for you
  2. This is not a shift click issue, but rather an issue with how the transmutation tablet consumes items for EMC in order to do the transmutation (see bug #1057)

With that said, going to close this issue and track the issue with the trans tablet in #1057