Equivalent Exchange 3

Equivalent Exchange 3

2M Downloads

initPortableSmeltingRecipes dependant of mod loading order

Deatrathias opened this issue ยท 5 comments

commented

The method initPortableSmeltingRecipes in RecipesTransmutationStone is called during Init. Since most mods make their smelting recipes in the Init, the recipes of mods loaded after EE3 are not added to the portable smelting. It would be better if it was done after every mod is done adding their recipes, for instance in the Post-init
Also, if, for some reason, the smelting result is an ItemStack of an Item that does not exist, it ends up in NPE on RecipeHelper.addSmeltingRecipe

commented

Okay, to me it seems this is an easy fix.

Please correct me if am wrong but the init method of the RecipesTransmutationStone is called from within EquivalentExchange3 class's init method, load. By the looks of it, the file also has a postInit method, modsLoaded, so I would assume you could put it there.

I tried putting it there. I didn't get any errors thrown and was still able to craft with the stone so I have to assume it worked

commented

The method was always meant to be temporary, but I'll see about moving it to @PostInit as it fits better there

commented

Thanks ! I reported this because it caused a crash with my mod and there was no ideal solution on my part to fix it.

commented

This should be able to be closed now, due to the fact that @EventHandler has taken @*Init's place.

commented

Closing since the code in question is long gone now