Equivalent Exchange 3

Equivalent Exchange 3

2M Downloads

Let Forge auto-install MCP in build.xml

winstliu opened this issue ยท 13 comments

commented

As it stands, people need to download MCP first, and then install Forge inside the MCP directory. I propose letting Forge install MCP for you, for the following reasons:

  • It brings us in line with the "new" way of Forge installation
  • There is one less step/place for human error
  • Forge doesn't end up destroying your directory structure and install MCP twice (mcp\forge\mcp)

If you support the change, pahimar, I'll submit the PR I have ready already ๐Ÿ˜‰
If not, I understand.

commented

Time to ask for another change:
MinecraftForge/FML#263 (comment) (I'm thinking that this should be middle-term integration, not short-term)

commented

It DOES. Forge automatically installs mcp. There's no need for it to be like buildcraft and one click compile it.

Take a close look at the build.xml or the README please. We need to "install" MCP first, then plop Forge inside it, then install Forge.

commented

It DOES. Forge automatically installs mcp. There's no need for it to be like buildcraft and one click compile it.

commented

^Correct.

commented

how about just moving over to GMCP it would make it a lot simpler :P

commented
  • gradle wrapper FTW
commented

... That was supposed to be a +

commented
commented

? it is this issue ...

commented

nop you can just install forge it Will install MCP for you .... I guess the README needs to be updated with that

commented

nop you can just install forge it Will install MCP for you .... I guess the README needs to be updated with that

Look at the build.xml. The directory path is mcp\forge. Which either means that you install MCP first, or you give Forge some arguments, which is pretty "advanced".

commented

ok so the build.xml also needs to get changed

commented

Click it. Github doesn't parse comments correctly.