Equivalent Exchange 3

Equivalent Exchange 3

Mods
2M Downloads

Alchemical chest Crashes, and the inventory slots are WAY off.

monster860 opened this issue ยท 3 comments

commented

The alchemical chest crashes when opened.

I did stuff with the Eclipse debugger, and found out that values were being skipped, causing an overflow error. This can be fixed by changing, in the 3 Chest container classes, the following lines:

        // Add the Alchemical Chest slots to the container
        for (int chestRowIndex = 0; chestRowIndex < CHEST_INVENTORY_ROWS; ++chestRowIndex)
        {
            for (int chestColumnIndex = 0; chestColumnIndex < CHEST_INVENTORY_COLUMNS; ++chestColumnIndex)
            {
                this.addSlotToContainer(new Slot(tileAlchemicalChest, chestColumnIndex + chestRowIndex * 13, 8 + chestColumnIndex * 18, 8 + chestRowIndex * 18));
            }
        }

to:

        // Add the Alchemical Chest slots to the container
        for (int chestRowIndex = 0; chestRowIndex < CHEST_INVENTORY_ROWS; ++chestRowIndex)
        {
            for (int chestColumnIndex = 0; chestColumnIndex < CHEST_INVENTORY_COLUMNS; ++chestColumnIndex)
            {
                //                                                                                        VVVV The change is to replace 13 with that
                this.addSlotToContainer(new Slot(tileAlchemicalChest, chestColumnIndex + chestRowIndex * CHEST_INVENTORY_COLUMNS, 8 + chestColumnIndex * 18, 8 + chestRowIndex * 18));
            }
        }

After testing the changes, I noticed the inventory slots were WAY off.

(I didn't feel like making a PR for such a simple fix)

EDIT: Created a PR. #560

commented

Always make PR's. It means you become a small contributor :)

commented

Okay, did that. #560

commented

See @monster860 You saved pahimar time :)