Equivalent Exchange 3

Equivalent Exchange 3

2M Downloads

Little bug with the Calcinator GUI

traxys opened this issue ยท 6 comments

commented

When the calcinator has done it's cooking the bar stays full on 0.2.54

commented

Fixed your ticket, since I don't think you meant to link to an old PR.

  1. I think you mean v0.2.54 (which is not one of my builds)
  2. Known bug, meaning to solve it when I have time
commented

It might just be me (on mobile, so can't search for field occurrences), but are you sending itemCookTime to the client at all?
Because checking whether it's done and resetting it to 0 only happens on the server in the tile update method.

commented

Nevermind found it. Can't you just check in ContainerCalcinator.updateProgressbar() if itemCookTime is bigger or equal to 200 and set it to 0. It's ugly, but probably a fix.

commented

@pahimar On TileCalcinator, line 303:

@SideOnly(Side.CLIENT)
    public int getBurnTimeRemainingScaled(int scale)
    {
        if (this.itemCookTime == 0)
        {
            this.itemCookTime = 200;
        }

        return this.deviceCookTime * scale / this.fuelBurnTime;
    }

If you get rid of that if statement it fixes it. Almost sure that's the cause, and I don't see why that piece of code was there in the first place, so could that be the solution?

commented

It probably is, mine would do the same, but yours actually fixes the source of the problem. :P

commented

@ItsMeElConquistador Yeah just tested it and it seems to be working just fine now.
Should I make a PR?