Electroblob's Wizardry

Electroblob's Wizardry

18M Downloads

syncAdvancements network spam

LemADEC opened this issue ยท 1 comments

commented

Minecraft version: 1.12.2
Wizardry version: 4.2.11
Environment: Server

Issue details:
When a player gets an achievement, the mod is sending multiple time the advancements to this player.

[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [ebwizardry]: Synchronising advancements for Nataleenix
[13:16:43] [Server thread/INFO] [minecraft/DedicatedServer]: Nataleenix has made the advancement [Diamonds!]

From a quick check of the code, all advancements progress are resent every time this is logged, so there's a network spam going on here.

Other mods involved: https://www.curseforge.com/minecraft/modpacks/fsg-arcania-craft/files/3020551

Link to crash report (if applicable): n/a

commented

Duplicate of #475.