Electroblob's Wizardry

Electroblob's Wizardry

Mods
18M Downloads

Forfeit mechanic not respecting claims.

jazoobio opened this issue ยท 2 comments

commented

Minecraft version: 1.12.2
Wizardry version: 4.3.4
Environment: Server

Issue details: Forfeits from unidentified spells don't respect claims. Examples of this are Earth (spawning water, collapsing the ground), Fire (Spawning fire around), Ice (Spawning ice/snow).

Other mods involved: FTBUtilities

commented

The only solution what comes to my mind is to prevent casting unknown spells at all in claimed chunks.
(Otherwise, causing the spell cast attempt in claimed chunks to fail only if these special block-affecting forfeits happen would be exploitable as you could always avoid these forfeits by casting them in claimed chunks.)

commented

Actually I think this may be fixable. It seems that when I overhauled claim mod interaction I forgot to apply the changes to the forfeit class. For example, here's the code for the water forfeit:

Wizardry/src/main/java/electroblob/wizardry/misc/Forfeit.java

Lines 405 to 411 in 486d55f

add(Tier.ADVANCED, Element.EARTH, create("flood", (w, p) -> {
if(!w.isRemote){
List<BlockPos> sphere = BlockUtils.getBlockSphere(p.getPosition().up(), 2);
sphere.removeIf(pos -> !BlockUtils.canBlockBeReplaced(w, pos, true));
sphere.forEach(pos -> w.setBlockState(pos, Blocks.WATER.getDefaultState()));
}
}));

It should use the wrapper methods in BlockUtils instead of calling setBlockState directly. I'll go through them all and make that change for the next patch.