Elemental Craft

Elemental Craft

Mods
13M Downloads

[1.16.4] Crash when clicking on item with info tab but no craftable recipe

ViRb3 opened this issue ยท 1 comments

commented

Modpack: ATM6 1.3.2
Mod: elementalcraft-1.16.3-2.4.10.jar
Forge: forge-35.1.3

I used KubeJS to disable crafting of a problematic item, unrelated to ElementalCraft. I also added JEI information about why it was removed. The result is when you click on the item, you see only one tab - the info tab - and no crafting recipes.

With ElementalCraft added, the game crashes as soon as I click on the item. Log: https://mcpaste.io/26452dc352b3acc0

commented

ElementalCraft/src/main/java/sirttas/elementalcraft/interaction/jei/ingredient/element/ElementIngredientRenderer.java

Line 19 in 99eb931

int amount = ingredient.getAmount();

ingredient here is not checked before use, but IIngredientRenderer can pass null here:

void render(MatrixStack matrixStack, int xPosition, int yPosition, @Nullable T ingredient);