Embeddium

Embeddium

37M Downloads

Pixies from Ice And Fire produce broken particles at certain angle and time

Matthysse opened this issue ยท 1 comments

commented

Bug Description

Pixies from the Ice And Fire mod (https://modrinth.com/mod/ice-and-fire-dragons) produce broken particles at certain angle and time

Reproduction Steps

  • Load game using Embeddium ((Neo)Forge), Ice And Fire
  • Wait a bit and see the particles from the pixies going broken at certain angles:
    2024-03-14_18 00 20

It's hard to reproduce and sometimes does not want to appear...

Log File

latest.log

commented

I wasn't able to reproduce this issue after a few minutes of spawning pixies with just Ice & Fire and Embeddium installed. However, I have a theory as to why it happens. This explanation will be a bit technical, so you may wish to make an issue with Ice & Fire and point them to this message.

When rendering pixie dust, Ice & Fire's rendering code changes the active texture and starts a buffer builder manually. This seems inconsistent with how other "custom" vanilla particles work, and seems potentially likely to cause the renderer to end up using the wrong texture or format when rendering particles later. I would suggest they change this code to use a similar strategy to vanilla's MobAppearanceParticle, which just uses the MultiBufferSource provided by vanilla with a custom render type, rather than controlling the renderer state themselves.

I'm going to close this issue on my end as I'm not convinced it's an Embeddium bug, and I won't be able to fix it without a reliable way to reproduce it.