Embeddium

Embeddium

37M Downloads

The ModernUI GUI scale hook is no longer working on 1.18.2+

BloCamLimb opened this issue ยท 0 comments

commented

Request Description

For Minecraft 1.18.2 to 1.19.4, the calcGuiScales is in icyllis.modernui.mc.forge.MuiForgeApi.
For Minecraft 1.20.1 and above, ModernUI has a multi-loader structure, the calcGuiScales has moved to icyllis.modernui.mc.MuiModApi
Including these class names to the candidate list is the way to go.

Related class: https://github.com/embeddedt/embeddium/blob/21.0/neoforge/src/main/java/org/embeddedt/embeddium/impl/compat/modernui/MuiGuiScaleHook.java

Postscript:
With the updates of ModernUI in the past two years, I have tweaked the GUI scale slider so that regardless of the current window resolution, users may choose a scale between 0 (auto) and MAX_GUI_SCALE (defined in MuiForgeApi or MuiModApi), and the effective scale will be clamped based on the current window resolution. This way, users can preset a large scale when the window resolution is small, and when the window is large enough, the scale set by the user will take effect.